Skip to content

feat(results): Add results list command#12

Merged
pthurlow merged 1 commit intomainfrom
feat/results-list
Mar 23, 2026
Merged

feat(results): Add results list command#12
pthurlow merged 1 commit intomainfrom
feat/results-list

Conversation

@pthurlow
Copy link
Copy Markdown
Collaborator

No description provided.

claude[bot]
claude bot previously requested changes Mar 23, 2026
Copy link
Copy Markdown
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

src/results.rs:109-112 — Pagination offset and displayed count are wrong.

body.count is almost certainly the total record count from the API (e.g. 50,000), not the count of items in the current page. This means:

  • The "showing N results" message shows the total, not what was actually rendered.
  • --offset {next} skips to offset + total instead of offset + page_size, breaking pagination entirely.

Fix: use body.results.len() for both the display count and the next-offset calculation (suggestion left inline).

Action Required

Replace body.count in the pagination hint block with body.results.len(). If the API does return count as the page-level count (not total), this is still the safer choice since results.len() is unambiguous.

@pthurlow pthurlow dismissed claude[bot]’s stale review March 23, 2026 22:34

Not a correct review analysis

@pthurlow pthurlow merged commit 34108f0 into main Mar 23, 2026
7 checks passed
@pthurlow pthurlow deleted the feat/results-list branch March 23, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant