Conversation
Contributor
There was a problem hiding this comment.
Review
Issues
src/results.rs:109-112 — Pagination offset and displayed count are wrong.
body.count is almost certainly the total record count from the API (e.g. 50,000), not the count of items in the current page. This means:
- The "showing N results" message shows the total, not what was actually rendered.
--offset {next}skips tooffset + totalinstead ofoffset + page_size, breaking pagination entirely.
Fix: use body.results.len() for both the display count and the next-offset calculation (suggestion left inline).
Action Required
Replace body.count in the pagination hint block with body.results.len(). If the API does return count as the page-level count (not total), this is still the safer choice since results.len() is unambiguous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.