chore(ci): bump Node 20 actions to Node 24 runtime#14
Open
zfarrell wants to merge 1 commit into
Open
Conversation
Comment on lines
74
to
106
| @@ -90,7 +90,7 @@ jobs: | |||
| python -c "import geodatafusion" | |||
|
|
|||
| - name: Upload wheels | |||
| uses: actions/upload-artifact@v4 | |||
| uses: actions/upload-artifact@v7.0.1 | |||
| with: | |||
| name: wheels-macos-${{ matrix.platform.target }} | |||
| path: dist | |||
| @@ -101,7 +101,7 @@ jobs: | |||
| matrix: | |||
| target: [x64] | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: actions/checkout@v6.0.2 | |||
|
|
|||
| - uses: actions/setup-python@v4 | |||
There was a problem hiding this comment.
nit: these two actions/setup-python@v4 references (lines 74 and 106) were left on v4, which runs on Node 16 — even older than the Node 20 versions this PR is bumping away from. They're inconsistent with the v5 -> v6.2.0 bump done in python.yml and with the PR's stated goal of clearing out pre-Node 24 actions. Recommend bumping both to actions/setup-python@v6.2.0 here as well. (not blocking)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps GitHub Actions still running on the deprecated Node 20 runtime to current Node 24-capable releases across CI and release workflows.
Bumps:
Breaking changes to review: