fix(ci): update workflow actions for Node.js 24 compatibility#13
fix(ci): update workflow actions for Node.js 24 compatibility#13zfarrell wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review
Issues
.github/workflows/python-wheels.yml, line 224 — upload-artifact@v6 / download-artifact@v7 version mismatch. All three wheel build jobs upload with upload-artifact@b7c566a7 # v6, but the release job downloads with download-artifact@37930b1c # v7. If the artifact API changed between v6 and v7, the release job will fail to find the uploaded artifacts — silently producing a broken or empty PyPI publish. These two actions must use a compatible major version.
Action Required
Align upload-artifact and download-artifact to the same major version. The simplest fix is updating the three upload steps (linux, macos, windows) to a v7 SHA to match the download step.
zfarrell
left a comment
zfarrell
left a comment
There was a problem hiding this comment.
The version numbers for upload-artifact and download-artifact don't need to match — they're independently versioned actions. upload-artifact@v6 and download-artifact@v7 are the current official latest releases and are fully compatible (both use the same artifact backend API).
Verified SHAs:
$ gh api repos/actions/upload-artifact/git/ref/tags/v6 --jq '.object.sha'
b7c566a772e6b6bfb58ed0dc250532a479d7789f
$ gh api repos/actions/download-artifact/git/ref/tags/v7 --jq '.object.sha'
37930b1c2abaa49bbe596cd826c3c89aef350131
1 participant
Update all GitHub Actions to Node.js 24 compatible versions with SHA pins.