feat: manual cleanup

[patrickleet]

Summary by CodeRabbit

• Chores

  • Updated continuous integration and deployment workflows to the latest versions for enhanced reliability and validation.
  • Optimized end-to-end testing infrastructure with improved resource cleanup strategies and adjusted timeout parameters for faster test execution.

• Tests

  • Enhanced test configuration for better resource management during testing cycles.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updates GitHub Actions workflow references from v2.15.0 to v2.16.0 across multiple CI/CD pipelines. E2E workflow branch switches to feat/delete-extra-resources with new deletion controls, reduced timeouts, and cleanup parameters. E2E test configuration sets skipDelete to True and restructures resource manifests.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow References .github/workflows/on-pr.yaml, on-push-main.yaml, on-version-tagged.yaml	Bumped validate, test, and publish workflow versions from v2.15.0 to v2.16.0; e2e workflow branch switched from feat/more-usage-debugging to feat/delete-extra-resources with new resource deletion controls (delete-root-resource, delete-extra-resources, manual-cleanup) and timeout reductions (timeout-minutes: 33, cleanup-timeout-minutes: 20, delete-extra-resources-timeout-minutes: 20).
E2E Test Configuration tests/e2etest-observe/main.k	Changed skipDelete from False to True; removed cleanup-order protection block; restructured manifests to separate AutoEKSCluster and Observe resources; added repo tag to AutoEKSCluster metadata.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Workflows hop to v2.16, so spry and bright,
Resources cleaned up, timeouts set right,
Delete-extra flags and Observe flows,
Where the cleanup magic goes! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat: manual cleanup' directly corresponds to the main change: introducing manual-cleanup controls across multiple workflow files and e2e test configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/manual-cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/on-pr.yaml:
- Line 45: Replace the fragile feature-branch reference
"unbounded-tech/workflows-crossplane/.github/workflows/e2e.yaml@feat/delete-extra-resources"
with a stable pinned ref (release tag or commit SHA) used in the other workflow
(see on-push-main.yaml) so the action points at a permanent version; after the
upstream feature is merged update the ref to the official release tag (or the
same stable ref used in on-push-main.yaml) to keep both workflows consistent and
avoid breakage.

In @.github/workflows/on-push-main.yaml:
- Line 41: The workflow references a feature branch in the uses statement
('unbounded-tech/workflows-crossplane/.github/workflows/e2e.yaml@feat/delete-extra-resources')
which is unsafe for a main branch; change that reference to a stable tag (for
example replace '@feat/delete-extra-resources' with a release tag like
'@v2.16.0') or, if the change is truly temporary, add a clear comment in the
same file near the uses line documenting that this is a short-lived reference
pending merge and who owns it, and ensure the PR that introduces this workflow
includes a follow-up task to update to the final tag.

---

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0bd1b6c and e51f8f7.

📒 Files selected for processing (4)

• .github/workflows/on-pr.yaml
• .github/workflows/on-push-main.yaml
• .github/workflows/on-version-tagged.yaml
• tests/e2etest-observe/main.k

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Same concern: feature branch reference is fragile.

As noted in on-push-main.yaml, using feat/delete-extra-resources branch reference is risky. This should be updated to a stable version once the feature is merged into the upstream workflow repository.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/on-pr.yaml at line 45, Replace the fragile feature-branch
reference
"unbounded-tech/workflows-crossplane/.github/workflows/e2e.yaml@feat/delete-extra-resources"
with a stable pinned ref (release tag or commit SHA) used in the other workflow
(see on-push-main.yaml) so the action points at a permanent version; after the
upstream feature is merged update the ref to the official release tag (or the
same stable ref used in on-push-main.yaml) to keep both workflows consistent and
avoid breakage.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Using a feature branch reference in production workflow is risky.

The e2e workflow references feat/delete-extra-resources branch instead of a stable version tag. This branch could be deleted, rebased, or force-pushed, causing this main branch workflow to break unexpectedly.

Consider using a stable version tag (e.g., v2.16.0) once the feature is merged, or at minimum document that this is a temporary state pending the feature branch merge.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/on-push-main.yaml at line 41, The workflow references a
feature branch in the uses statement
('unbounded-tech/workflows-crossplane/.github/workflows/e2e.yaml@feat/delete-extra-resources')
which is unsafe for a main branch; change that reference to a stable tag (for
example replace '@feat/delete-extra-resources' with a release tag like
'@v2.16.0') or, if the change is truly temporary, add a clear comment in the
same file near the uses line documenting that this is a short-lived reference
pending merge and who owns it, and ensure the PR that introduces this workflow
includes a follow-up task to update to the final tag.

[github-actions]

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/stack-aws-observe:pr-2-cc57b6e9a4eaf9854c259e0b38be49e942287b71

View Package