Open
Conversation
Batch-fetches destinations from tenant store and displays them via registry when include=destination is requested. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Decouples display logic from destregistry.Registry via a destinationDisplayer interface used by both DestinationHandlers and LogHandlers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Surface unexpected errors from RetrieveDestination/Display instead of silently swallowing (deleted/not-found destinations still skip gracefully) - Mark response_data, event, destination as nullable in OpenAPI spec - Add include=destination to all 4 attempt endpoint descriptions in spec - Add tests: destination-scoped list with include, deleted destination on both retrieve and list Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add ListDestination method with TenantID + IDs + Type + Topics filters, replacing the old ListDestinationByTenant variadic-opts API. This enables batch-fetch by ID (used in listAttemptsInternal to eliminate N+1 calls) and provides a cleaner filter interface. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexluong
changed the title
…lision Also remove unnecessary slice copy in HMGET args and dead `_ = data`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ayList Remove unnecessary interface + wrapper struct pattern. Add DisplayList helper to consolidate repeated display loop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
alexbouchardd
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?include=destinationon attempts endpoints: List and retrieve attempts can now include the full destination object in responses, avoiding extra API calls for clientsListDestinationmethod: Adds batch-fetch capability withTenantID+IDs+Type+Topicsfilters, replacing the oldListDestinationByTenantvariadic-opts APIlistAttemptsInternalnow groups destination IDs by tenant and batch-fetches viaListDestinationinstead of callingRetrieveDestinationper unique destinationListDestinationByTenant: All callers migrated, old interface method + types (ListDestinationByTenantOpts,DestinationFilter,WithDestinationFilter) removedCommits
d1848189?include=destinationto list/retrieve attempts endpointsfa0083a9destinationDisplayerinterface for testabilityca98ddbe23dd03ffListDestinationByTenantwithListDestinationTest plan
go build ./...passesgo vet ./...passesgo test ./internal/tenantstore/... -count=1— all pass (memtenantstore + redistenantstore)go test ./internal/apirouter/... -count=1— all passListDestination(IDs filter, deleted exclusion, wrong tenant, type/topics filters)🤖 Generated with Claude Code