Add Clerk authentication with Angular login component and Electron IPC token storage#635
Add Clerk authentication with Angular login component and Electron IPC token storage#635
Conversation
… Electron IPC support Agent-Logs-Url: https://github.com/highperformancecoder/minsky/sessions/dcea3c3b-13de-494d-88b9-bdc278391926 Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
|
@copilot I have added a menu item to call the /login route, but the window doesn't render, and the developer tools window doesn't attach, so I can't debug why it is stalling. |
Agent-Logs-Url: https://github.com/highperformancecoder/minsky/sessions/ac00893a-9811-4d4f-8ef1-9b889eb6d5cc Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
The window wasn't rendering because the menu item was calling Fixed in commit |
|
@copilot The login window is including and which it shouldn't. I can't see these things in the login.component.html file, so where are they coming from?
|
Your comment appears to have been cut off — it ends with "The login window is including". Could you complete the description of what you're seeing so I can investigate? |
|
@copilot The login window is including the minsky-header tag and the div with class example-button-row, that its shouldn't. I can't see this in login.component.html, so have no idea where they are coming from. |
…oute from main layout Agent-Logs-Url: https://github.com/highperformancecoder/minsky/sessions/ce140fa8-df43-43d0-832d-90cac7a292b8 Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
The Fixed in commit |
|
@copilot - why not just use /headless like the other windows? Seems simpler |
…indows Agent-Logs-Url: https://github.com/highperformancecoder/minsky/sessions/0bde9861-8dca-48e7-965d-c608f6258171 Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
Done in commit |
|
@copilot Thanks - looks good. What I need now is to add a promise that I can wait on - so call /headless/login and have a promise I can await on that is resolved when the token is set in the StoreManager. |
Agent-Logs-Url: https://github.com/highperformancecoder/minsky/sessions/f860580e-1854-46ba-96ed-117e3d0cfdce Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
Done in commit import { openLoginWindow } from '../events/electron.events';
const token = await openLoginWindow();
if (token) { /* proceed with authenticated request */ }The |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts
Dismissed
Show dismissed
Hide dismissed
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe changes introduce a Clerk-based authentication system integrated with Electron, featuring a login component, IPC handlers for auth token persistence, backend API communication for upgrades, and menu options for user authentication and upgrade workflows. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LoginUI as Login<br/>Component
participant ClerkSvc as ClerkService
participant Clerk as Clerk<br/>Client
participant Electron as Electron<br/>IPC
participant Store as Store<br/>Manager
User->>LoginUI: Navigate to login
LoginUI->>ClerkSvc: initialize()
ClerkSvc->>Clerk: Create & load Clerk instance
Clerk-->>ClerkSvc: Initialized
ClerkSvc-->>LoginUI: Ready
User->>LoginUI: Enter email & password
LoginUI->>LoginUI: Validate form
LoginUI->>ClerkSvc: signInWithEmailPassword(email, password)
ClerkSvc->>Clerk: signIn.create(email, password)
Clerk-->>ClerkSvc: SignIn result
alt Sign-in successful
ClerkSvc->>Clerk: Activate session
ClerkSvc->>ClerkSvc: getToken()
Clerk-->>ClerkSvc: JWT token
ClerkSvc->>Electron: sendTokenToElectron()
Electron->>Electron: IPC: SET_AUTH_TOKEN
Electron->>Store: Update authToken
Store-->>Electron: Success
Electron-->>ClerkSvc: Response
ClerkSvc-->>LoginUI: Success
LoginUI->>Electron: closeWindow()
else Sign-in failed
ClerkSvc-->>LoginUI: Error
LoginUI->>User: Display error message
end
sequenceDiagram
participant User
participant App as Electron<br/>App
participant Menu as Application<br/>Menu
participant CmdMgr as CommandsManager
participant WinMgr as WindowManager
participant Backend as Backend<br/>API
participant Clerk as Clerk<br/>Auth
participant Store as Store
User->>Menu: Click "Upgrade via Clerk"
Menu->>CmdMgr: upgradeUsingClerk()
CmdMgr->>WinMgr: openLoginWindow()
WinMgr-->>CmdMgr: Promise<token>
CmdMgr->>CmdMgr: Wait for auth token
Note over App: User authenticates in login window
App->>Store: SET_AUTH_TOKEN event
Store->>WinMgr: _resolveAuthToken(token)
WinMgr-->>CmdMgr: Token received
CmdMgr->>CmdMgr: buildState(previous)
CmdMgr->>Backend: getRelease(product, previous, token)
Backend-->>CmdMgr: Download URL
CmdMgr->>CmdMgr: getFinalUrl() with redirect handling
CmdMgr->>CmdMgr: Download & install assets
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 12
🧹 Nitpick comments (4)
gui-js/apps/minsky-web/src/environments/environment.web.ts (1)
9-9: Use a non-empty dev value or explicit startup guard for Clerk key.Line 9 is
''; if Clerk init is switched to config-driven loading, this will fail at runtime with little context. Prefer a real dev key or fail fast with a clear error when unset.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@gui-js/apps/minsky-web/src/environments/environment.web.ts` at line 9, The environment value clerkPublishableKey is an empty string which will cause silent runtime failures when Clerk is initialized; either set a non-empty development publishable key in environment.web.ts (clerkPublishableKey) or add a startup guard where Clerk is initialized that checks environment.clerkPublishableKey and throws/logs a clear error and exits if unset. Update the environment.web.ts constant and/or the Clerk init path to validate clerkPublishableKey before calling the Clerk SDK (e.g., initClerk or wherever Clerk is created) so failures are fast and informative.gui-js/apps/minsky-electron/src/app/managers/ApplicationMenuManager.ts (1)
135-137:Logout Clerklabel does not match the action.Line 136 opens the login window; it does not perform an immediate logout. Either rename this item (e.g., “Clerk Login / Manage Session”) or call a direct logout/clear-token flow.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@gui-js/apps/minsky-electron/src/app/managers/ApplicationMenuManager.ts` around lines 135 - 137, The menu item labeled "Logout Clerk" currently calls WindowManager.openLoginWindow() which only opens the login UI and does not perform a logout; update the menu to either rename the label to reflect the action (e.g., "Clerk Login / Manage Session") or change the click handler to invoke the actual logout/clear-token flow (for example call your logout routine such as AuthService.logout() or SessionManager.clearSession() before or instead of WindowManager.openLoginWindow()); ensure the label and the click handler are consistent (update the label 'Logout Clerk' or replace WindowManager.openLoginWindow() with the real logout function).gui-js/libs/ui-components/src/lib/login/login.component.html (1)
27-27: Announce auth failures to assistive tech.The general
errorMessageis only visually rendered right now, so screen-reader users may miss failed sign-ins.♿ Suggested tweak
- <p *ngIf="errorMessage" class="error-message">{{ errorMessage }}</p> + <p *ngIf="errorMessage" class="error-message" role="alert">{{ errorMessage }}</p>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@gui-js/libs/ui-components/src/lib/login/login.component.html` at line 27, The error message paragraph (the element that displays errorMessage in login.component.html) is only visually rendered and not announced to assistive tech; update that element to be an accessible live region by adding attributes such as aria-live="assertive" and role="alert" (and optionally aria-atomic="true") so screen readers will announce sign-in failures when errorMessage is set; locate the <p> that binds to errorMessage and add these attributes to it.gui-js/libs/core/src/lib/services/clerk/clerk.service.ts (1)
35-60: Consider sending the Electron token as part of sign-in.A successful
signInWithEmailPassword()still requires callers to remember a secondsendTokenToElectron()call. Missing that step would leave Electron waiting onSET_AUTH_TOKENeven though Clerk already created a session.♻️ Suggested refactor
if (result.status === 'complete') { await this.clerk.setActive({ session: result.createdSessionId }); + await this.sendTokenToElectron(); } else {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@gui-js/libs/core/src/lib/services/clerk/clerk.service.ts` around lines 35 - 60, signInWithEmailPassword currently completes Clerk sign-in but doesn't notify Electron, leaving the renderer waiting for SET_AUTH_TOKEN; after successfully setting the active session in signInWithEmailPassword, call sendTokenToElectron (or inline the logic: await this.getToken() then this.electronService.invoke(events.SET_AUTH_TOKEN, token) when this.electronService.isElectron) so the token is sent automatically; update signInWithEmailPassword to await sendTokenToElectron() only on success and keep existing signOut behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@gui-js/apps/minsky-electron/src/app/events/electron.events.ts`:
- Around line 292-297: The handler for ipcMain.handle(events.SET_AUTH_TOKEN) is
persisting the raw bearer token to disk via StoreManager.store.set/delete
(StoreManager.store), which is insecure; update the handler to stop writing the
token to persistent store and instead keep it in memory (e.g., use or create an
in-memory AuthTokenManager singleton or a module-scoped variable accessed by the
renderer via IPC) and remove calls to StoreManager.store.set/delete; if
persistent storage is absolutely required, replace direct disk persistence with
an OS-backed secret store integration (e.g., keytar or platform-specific secure
storage) and ensure any persisted value is encrypted and has a strict
expiry/rotation policy rather than storing the raw bearer token.
In `@gui-js/apps/minsky-electron/src/app/managers/ApplicationMenuManager.ts`:
- Around line 131-133: The "Upgrade via Clerk" menu action currently spins in a
non-cancelable loop; modify CommandsManager.upgradeUsingClerk to stop reopening
the login when WindowManager.openLoginWindow returns null (user
closed/cancelled) by handling a null/undefined authToken result and aborting the
upgrade flow (or returning an explicit cancellation) instead of looping forever;
optionally replace the infinite while (!authToken) with a finite retry policy or
a user confirmation prompt before retrying so the operation can be cancelled by
the user.
In `@gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts`:
- Around line 1469-1488: getRelease currently swallows backend/auth failures by
returning a falsy URL (via optional chaining and a catch that returns ""), so
upgradeUsingClerk sees "no update" instead of surfacing errors; update
getRelease (the static method) to stop collapsing errors: remove or change the
catch to rethrow the caught error (or throw a new Error with context) so
auth/backend failures propagate, and explicitly validate the parsed response
(check that the parsed object from callBackendAPI and
release.release.download_url exist) before returning the URL — only return an
empty string when you deterministically know there is no release (e.g., no
prevRelease found when previous==true), but do not suppress exceptions from
callBackendAPI or malformed responses.
- Around line 1491-1494: The loop in CommandsManager.upgradeUsingClerk
continuously calls WindowManager.openLoginWindow() until
StoreManager.store.get('authToken') exists, but openLoginWindow() can resolve
null when the user closes the popup; update upgradeUsingClerk to capture the
result of WindowManager.openLoginWindow(), check for null, and
break/return/throw to allow cancelation instead of immediately reopening the
dialog—use the returned value from openLoginWindow() (or a boolean) before
re-checking StoreManager.store.get('authToken') so a closed popup stops the loop
and cancels the upgrade flow.
- Around line 1503-1505: The stored Ravel URL is resolved without the auth
token, causing future installs to use "Bearer undefined"; update the stash logic
so StoreManager.store.set('ravelPlugin', await getFinalUrl(ravelAsset, token))
passes the same auth token that other getFinalUrl calls in this file use (e.g.
the authToken/AuthManager.getToken() value present in CommandsManager). Ensure
you retrieve the current token the same way as other code in this module and
pass it as the second argument to getFinalUrl when ravelAsset is truthy.
- Around line 1399-1405: The default (unsupported-platform) branch in
CommandsManager.ts calls an out-of-scope window.close(), which throws; remove
that call and ensure the flow exits cleanly after
dialog.showMessageBoxSync(WindowManager.getMainWindow(), ...) — either delete
the window.close() line or replace it with a valid call on the WindowManager
(e.g., WindowManager.getMainWindow().close() or app.quit()) so the dialog is
shown and the process exits without referencing an undefined window identifier.
- Around line 1385-1398: The `case 'linux'` block in CommandsManager.ts declares
lets (aexec, osRelease, distroInfo, extractor, state assignment) that leak
across the switch and trigger the noSwitchDeclarations lint rule; fix it by
wrapping the entire case 'linux' body in { ... } so those let/const bindings are
block-scoped and local to that case (ensure you move the existing code for case
'linux' including state={...}, promisify(exec) assignment, os-release selection,
grep calls and extractor usage inside the new braces and keep the final break).
In `@gui-js/apps/minsky-electron/src/app/managers/StoreManager.ts`:
- Line 22: The StoreManager currently persists a sensitive authToken property in
electron-store; instead remove authToken from the persisted store schema and
move storage to the OS credential vault (e.g., use keytar). Update StoreManager
to stop writing/reading authToken from electron-store: add async methods like
getAuthToken/setAuthToken/deleteAuthToken that call keytar (or another OS
credential API), migrate any existing token on startup by reading the old
electron-store value, saving it to keytar, and deleting it from electron-store,
and keep only non-sensitive session state in electron-store.
In `@gui-js/apps/minsky-electron/src/app/managers/WindowManager.ts`:
- Around line 31-32: openLoginWindow currently overwrites the shared resolver
_resolveAuthToken when called a second time, orphaning the first caller; fix by
detecting an in-flight auth promise/resolver and returning that existing promise
instead of creating a new one, and only create/assign a new _resolveAuthToken
and _authTokenPromise when none exists; ensure you also reuse any existing
_loginWindow instead of creating a second popup (see references to
openLoginWindow, _resolveAuthToken, _authTokenPromise and _loginWindow and the
similar logic around lines 387-398) so multiple callers share the same
promise/window rather than replacing the resolver.
In `@gui-js/apps/minsky-web/src/environments/environment.ts`:
- Around line 6-8: You added a standalone environment object with
clerkPublishableKey instead of adding it to the existing AppConfig, so the value
can be unused; modify the code to move clerkPublishableKey into the existing
AppConfig interface/object (extend the AppConfig declaration to include
clerkPublishableKey and set its value there) and remove the separate environment
export, then update ClerkService to read the key from the injected AppConfig
(use the AppConfig property rather than a hardcoded string) so the publishable
key is consistently sourced from the app config.
In `@gui-js/libs/core/src/lib/services/clerk/clerk.service.ts`:
- Around line 18-20: The publishable key is hard-coded as publishableKey and
passed to new Clerk(...) in ClerkService; instead accept the publishable key
from the app-level configuration (e.g. inject a ConfigService or add a
constructor parameter) and use that value when instantiating Clerk (this.clerk =
new Clerk(config.get('CLERK_PUBLISHABLE_KEY'))), including a clear error or
fallback if the config value is missing; update the ClerkService
constructor/initialization to read the injected config and remove the hard-coded
literal.
In `@gui-js/libs/ui-components/src/lib/login/login.component.ts`:
- Around line 54-73: The window is closed unconditionally after onSubmit which
prevents retries on failure and can crash outside Electron; change logic so
electronService.closeWindow() is only called for successful flows and only when
running in Electron: move the closeWindow call into the successful branch after
setting isAuthenticated (inside the try after sendTokenToElectron) and call it
guarded by the Electron runtime check (e.g., electronService.isElectron() or
electronService?.isElectron) or by checking that electronService.closeWindow
exists; apply the same pattern to the signOut flow (the signOut handler) so
signOut only calls electronService.closeWindow() when running in Electron and
after a successful sign-out.
---
Nitpick comments:
In `@gui-js/apps/minsky-electron/src/app/managers/ApplicationMenuManager.ts`:
- Around line 135-137: The menu item labeled "Logout Clerk" currently calls
WindowManager.openLoginWindow() which only opens the login UI and does not
perform a logout; update the menu to either rename the label to reflect the
action (e.g., "Clerk Login / Manage Session") or change the click handler to
invoke the actual logout/clear-token flow (for example call your logout routine
such as AuthService.logout() or SessionManager.clearSession() before or instead
of WindowManager.openLoginWindow()); ensure the label and the click handler are
consistent (update the label 'Logout Clerk' or replace
WindowManager.openLoginWindow() with the real logout function).
In `@gui-js/apps/minsky-web/src/environments/environment.web.ts`:
- Line 9: The environment value clerkPublishableKey is an empty string which
will cause silent runtime failures when Clerk is initialized; either set a
non-empty development publishable key in environment.web.ts
(clerkPublishableKey) or add a startup guard where Clerk is initialized that
checks environment.clerkPublishableKey and throws/logs a clear error and exits
if unset. Update the environment.web.ts constant and/or the Clerk init path to
validate clerkPublishableKey before calling the Clerk SDK (e.g., initClerk or
wherever Clerk is created) so failures are fast and informative.
In `@gui-js/libs/core/src/lib/services/clerk/clerk.service.ts`:
- Around line 35-60: signInWithEmailPassword currently completes Clerk sign-in
but doesn't notify Electron, leaving the renderer waiting for SET_AUTH_TOKEN;
after successfully setting the active session in signInWithEmailPassword, call
sendTokenToElectron (or inline the logic: await this.getToken() then
this.electronService.invoke(events.SET_AUTH_TOKEN, token) when
this.electronService.isElectron) so the token is sent automatically; update
signInWithEmailPassword to await sendTokenToElectron() only on success and keep
existing signOut behavior unchanged.
In `@gui-js/libs/ui-components/src/lib/login/login.component.html`:
- Line 27: The error message paragraph (the element that displays errorMessage
in login.component.html) is only visually rendered and not announced to
assistive tech; update that element to be an accessible live region by adding
attributes such as aria-live="assertive" and role="alert" (and optionally
aria-atomic="true") so screen readers will announce sign-in failures when
errorMessage is set; locate the <p> that binds to errorMessage and add these
attributes to it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 33112e71-d975-4bcc-90af-1cf487513a1c
⛔ Files ignored due to path filters (1)
gui-js/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (17)
gui-js/apps/minsky-electron/src/app/events/electron.events.tsgui-js/apps/minsky-electron/src/app/managers/ApplicationMenuManager.tsgui-js/apps/minsky-electron/src/app/managers/CommandsManager.tsgui-js/apps/minsky-electron/src/app/managers/StoreManager.tsgui-js/apps/minsky-electron/src/app/managers/WindowManager.tsgui-js/apps/minsky-web/src/app/app-routing.module.tsgui-js/apps/minsky-web/src/app/app.component.htmlgui-js/apps/minsky-web/src/environments/environment.tsgui-js/apps/minsky-web/src/environments/environment.web.tsgui-js/libs/core/src/index.tsgui-js/libs/core/src/lib/services/clerk/clerk.service.tsgui-js/libs/shared/src/lib/constants/constants.tsgui-js/libs/ui-components/src/index.tsgui-js/libs/ui-components/src/lib/login/login.component.htmlgui-js/libs/ui-components/src/lib/login/login.component.scssgui-js/libs/ui-components/src/lib/login/login.component.tsgui-js/package.json
gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts
Outdated
Show resolved
Hide resolved
gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts
Outdated
Show resolved
Hide resolved
| // Pending resolver for the auth-token promise created by openLoginWindow() | ||
| static _resolveAuthToken: ((token: string | null) => void) | null = null; |
There was a problem hiding this comment.
Reuse the in-flight login promise/window.
A second openLoginWindow() call replaces _resolveAuthToken before the first promise settles. The first caller then waits forever, and the earlier popup becomes orphaned. This is reachable because both the upgrade flow and the menu can open the login window. Return the existing pending promise instead of overwriting the resolver.
Also applies to: 387-398
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@gui-js/apps/minsky-electron/src/app/managers/WindowManager.ts` around lines
31 - 32, openLoginWindow currently overwrites the shared resolver
_resolveAuthToken when called a second time, orphaning the first caller; fix by
detecting an in-flight auth promise/resolver and returning that existing promise
instead of creating a new one, and only create/assign a new _resolveAuthToken
and _authTokenPromise when none exists; ensure you also reuse any existing
_loginWindow instead of creating a second popup (see references to
openLoginWindow, _resolveAuthToken, _authTokenPromise and _loginWindow and the
similar logic around lines 387-398) so multiple callers share the same
promise/window rather than replacing the resolver.
There was a problem hiding this comment.
openLoginWindow does return the promise. _resolveToken stores the returned token. It shouldn't matter if this gets overwritten, as node does this atomically, IIUC.
There was a problem hiding this comment.
@highperformancecoder, you're absolutely right that Node.js's single-threaded event loop makes the assignment itself atomic — no torn writes or data races there.
The concern is a logical one rather than a concurrency/atomicity one. Here's what happens with two sequential (but overlapping) calls:
- Call 1:
promise1is created; its internalresolve1is stored in_resolveAuthToken.promise1is returned to caller 1. - Call 2:
_resolveAuthTokenis overwritten withresolve2. At this point,resolve1is no longer reachable from anywhere — the only reference to it was_resolveAuthToken, and that's gone. - When the IPC handler fires
_resolveAuthToken(token), it callsresolve2→promise2settles. ✅ promise1never settles — caller 1 awaits it forever. 🔴
The window1.once('closed') handler also checks _resolveAuthToken, which by now either points to resolve2 or is already null, so it doesn't help promise1 either.
That said, if the application ensures only one login window can be opened at a time (e.g., it's purely user-triggered via a single menu item and the menu is disabled while the window is open), this is low-risk in practice. If you're confident that's the case, the current code is fine for practical purposes.
🧠 Learnings used
Learnt from: highperformancecoder
Repo: highperformancecoder/minsky PR: 630
File: RESTService/addon.cc:255-264
Timestamp: 2026-03-22T22:13:42.606Z
Learning: In Minsky (model/renderNativeWindow.cc, model/minsky.cc), `RenderNativeWindow::requestRedraw()` may only ever be called on the minsky thread (not from the RK/simulation thread). The simulation thread already explicitly avoids calling `requestRedraw()` via the guard `if (!RKThreadRunning) canvas.requestRedraw()` at model/minsky.cc:1276. If this invariant holds everywhere, the data race on `nativeWindowsToRedraw` reported in PR `#630` does not exist, and the swap-before-lock pattern introduced by that PR (releasing `nativeWindowsToRedrawMutex` before acquiring `minskyCmdMutex`) creates a new use-after-free hazard that is worse than the original code.
There was a problem hiding this comment.
_resolveAuthToken is only overwritten when the promise resolves. The promise is not stored there. Let's say promise1 resolves first, then _resolveAuthToken is updated to that value. promise 2 is still alive, and being awaited on. Meanwhile, login window 1 proceeds, as it has the token. Then promise 2 resolves, _resolveAuthToken is updated with the exact same token, and the second upgradeUsingClerk method continues, duplicating everything the first method has done. I don't see the problem here.
Agent-Logs-Url: https://github.com/highperformancecoder/minsky/sessions/fee97c92-7978-4c1d-8195-ace7a1267507 Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
Agent-Logs-Url: https://github.com/highperformancecoder/minsky/sessions/198fce2f-6377-4ea0-a84d-1c4fe6545b1b Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
…erk-session-login-window Preserve Clerk session between login window opens
SET_AUTH_TOKENevent constant togui-js/libs/shared/src/lib/constants/constants.tsgui-js/libs/ui-components/src/lib/login/login.component.tsgui-js/libs/ui-components/src/lib/login/login.component.htmlgui-js/libs/ui-components/src/lib/login/login.component.scssgui-js/libs/core/src/lib/services/clerk/clerk.service.tsgui-js/apps/minsky-electron/src/app/events/electron.events.tsto handle JWT token and exportopenLoginWindow(): Promise<string | null>/headless/loginroute (consistent with other popup windows), Clerk config to environment,@clerk/clerk-jsdependencycreatePopupWindowWithRouting(which prependsrendererAppURL) instead of bareloadURLclerk.service.tsopenLoginWindow(): Promise<string | null>fromelectron.events.ts— opens the#/headless/loginpopup and resolves with the JWT token onceSET_AUTH_TOKENfires, ornullif the window is closed before authentication completesOriginal prompt
Create Angular Login Component for Clerk with Electron Integration
Context
The minsky application is an Angular + Electron application located in the
gui-jsdirectory. It uses:gui-js/apps/minsky-webandgui-js/apps/minsky-electron)ipcRendererandipcMainObjectives
Create a complete Clerk authentication integration with the following components:
1. Angular Login Component
Create a new standalone Angular component at
gui-js/libs/ui-components/src/lib/login/login.component.tsthat:@clerk/clerk-js2. Clerk Service
Create an Angular service at
gui-js/libs/core/src/lib/services/clerk/clerk.service.tsthat:ElectronServiceto send tokens via IPC3. Electron Backend Integration
Update the Electron backend to:
gui-js/apps/minsky-electron/src/app/events/electron.events.tsto receive JWT tokensStoreManager)4. Environment Configuration
Update environment files to include Clerk configuration:
gui-js/apps/minsky-web/src/environments/environment.web.ts5. Package Dependencies
Update
gui-js/package.jsonto include:@clerk/clerk-jsfor Clerk SDK6. Export and Integration
gui-js/libs/ui-components/src/index.tsgui-js/libs/core/src/index.tsgui-js/apps/minsky-web/src/app/app-routing.module.ts)Technical Requirements
IPC Communication Pattern
Follow the existing IPC pattern:
Component Structure
Follow the existing standalone component pattern:
Service Pattern
Follow the existing service pattern with dependency injection:
Files to Create
gui-js/libs/ui-components/src/lib/login/login.component.tsgui-js/libs/ui-components/src/lib/login/login.component.htmlgui-js/libs/ui-components/src/lib/login/login.component.scssgui-js/libs/core/src/lib/services/clerk/clerk.service.tsgui-js/libs/shared/src/lib/events.ts(update to add new event constant)Files to Modify
gui-js/apps/minsky-electron/src/app/events/electron.events.ts- Add JWT token handlergui-js/libs/ui-components/src/index.ts- Export login componentgui-js/libs/core/src/index.ts- Export Clerk servicegui-js/apps/minsky-web/src/environments/environment.web.ts- Add Clerk configgui-js/package.json- Add Clerk dependencygui-js/apps/minsky-web/src/app/app-routing.module.ts- Add login route (optional, for demonstration)Implementation Notes
electronService.isElectron)Security Considera...
This pull request was created from Copilot chat.
This change is
Summary by CodeRabbit
Release Notes