fix: Update unit test for test_query.py #1047
Open
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
manishdait
force-pushed
the
fix/query_unit_test
branch
from
d694176 to
27472b4
Compare
Contributor
|
We are blocked @nadineloepfe on fixing the query issues and TLS as there is currently a problem in solo |
Contributor
|
@Akshat8510 for reference |
Contributor
|
Request review fixing query issue @nadineloepfe thank you |
exploreriii
approved these changes
Dec 11, 2025
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
manishdait
force-pushed
the
fix/query_unit_test
branch
from
27472b4 to
05b5b59
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the unit test failures described in Issue #1039.
After the recent node PR, Executable introduced node_account_ids and node_account_id, but these values were never populated for Query. Previously, queries inherited node account IDs from the client in Query class, but with the updated design, they are expected to default to empty unless explicitly set.
Related issue(s):
Fixes #1039
Notes for reviewer:
Checklist