-
Notifications
You must be signed in to change notification settings - Fork 108
fix: TLS Hostname Mismatch & Certificate Verification Failure for Nodes #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Akshat8510 for reference |
|
@manishdait please rebase |
emiliyank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to run the integration tests locally against testnet and with this fix they work fine.
fbea200 to
91eac51
Compare
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
91eac51 to
e1c3bb3
Compare
| return None | ||
| return [('grpc.ssl_target_name_override', self._authority_override)] | ||
| options = [ | ||
| ("grpc.default_authority", "127.0.0.1"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to set this to loca host ? Can we set a=a to something non existent ?
Description:
This PR addresses TLS hostname overrides for certificate validation in the Python SDK, ensuring secure gRPC connections to Hedera nodes.
Changes Made:
Related issue(s):
Fixes #1032
Notes for reviewer:
Checklist