-
Notifications
You must be signed in to change notification settings - Fork 108
feat: add issue reminder bot #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: prajeeta pal <prajeetapal@gmail.com>
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! From the Hiero Python SDK Team |
Signed-off-by: prajeeta <96904203+prajeeta15@users.noreply.github.com>
Signed-off-by: prajeeta pal <prajeetapal@gmail.com>
Signed-off-by: prajeeta <96904203+prajeeta15@users.noreply.github.com>
|
Request review if available @hiero-ledger/hiero-sdk-python-triage |
|
Hi @prajeeta15 |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prajeeta15
Have you tested this on a fork?
Please follow https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/testing_forks.md
Please ensure it posts on your fork issues for the test, then send a link of the bot working correctly
you'll need to enable issues on your fork by clicking inside settings
Signed-off-by: prajeeta pal <prajeetapal@gmail.com>
I tested on my fork by following https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/testing_forks.md |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prajeeta15
Would you mind adding some more explicit safety nets?
Otherwise happy to approve this
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| REPO: ${{ github.repository }} | ||
| DAYS: 7 | ||
| DRY_RUN: ${{ inputs.dry_run }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are passing
DRY_RUN="" i think
So on scheduled runs it passes empty
then inside the script it turns false in line 12
i think it will be clearer if we pass false here on workflow runs so the user knows what the workflow will do
| inputs: | ||
| dry_run: | ||
| description: "Dry run (log only, do not post comments)" | ||
| required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either make it really clear DRY run can only be true or false, or, allow yes/1 too
this is important because some of our dry runs use 1, but if a user types those in now, it will not pick them up and assign false


Description:
Add automated reminder for assigned issues with no linked pull requests
This PR introduces a new ReminderBot workflow that automatically notifies contributors when an issue has been assigned for 7+ days but no pull request has been created. This helps ensure that issues do not remain assigned indefinitely without progress.
What’s included:
.github/scripts/issue_reminder_no_pr.sh.github/workflows/bot-issue-reminder-no-pr.yml- Runs daily at 10:00 UTC
- Supports manual triggering via workflow_dispatch
- Uses GITHUB_TOKEN with appropriate permissions
The reminder message posted is:
"Hi, this is ReminderBot. This issue has been assigned but has had no pull request created. Are you still planning on working on the issue?
From the Python SDK Team"
Fixes #951
Notes for reviewer: