chore: move account allowance example to correct folder #1007
Conversation
Signed-off-by: Shamitha Raj <shamitharaj318@gmail.com>
|
Request review @tech0priyanshu |
|
Hi, this is WorkflowBot.
|
| @@ -1,7 +1,5 @@ | |||
| """ | |||
| Example demonstrating hbar allowance approval and usage. | |||
| Run: | |||
There was a problem hiding this comment.
please don't delete this line
There was a problem hiding this comment.
this issue is outstanding, please take a look at what you are submitting:
https://github.com/hiero-ledger/hiero-sdk-python/pull/1007/files
ntoe you have deeted lines 1-4
tech0priyanshu
left a comment
tech0priyanshu
left a comment
There was a problem hiding this comment.
The refactoring looks good - removing delete_hbar_allowance and negative tests from this file makes sense since they already exist in account_allowance_delete_transaction_hbar.py
Thanks, and welcome! 🎉 Great to have your first contribution much appreciated! @tWiLighT-xY91
|
changing to draft while its ready to review again :) |
|
[commit-verification-bot] To achieve verified status, please read: Remember, you require a GPG key and each commit must be signed with: Thank you for contributing! From the Hiero Python SDK Team |
tWiLighT-xY91
force-pushed
the
fix/move-allowance
branch
from
d24adfc to
ae8e64c
Compare
Signed-off-by: Shamitha Raj <shamitharaj318@gmail.com>
tWiLighT-xY91
force-pushed
the
fix/move-allowance
branch
from
a715a58 to
b6c3f6b
Compare
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! From the Hiero Python SDK Team |
Signed-off-by: Shamitha Raj <twilightmorningstar32@gmail.com>
| @@ -1,7 +1,5 @@ | |||
| """ | |||
| Example demonstrating hbar allowance approval and usage. | |||
| Run: | |||
There was a problem hiding this comment.
this issue is outstanding, please take a look at what you are submitting:
https://github.com/hiero-ledger/hiero-sdk-python/pull/1007/files
ntoe you have deeted lines 1-4
|
Hi @tWiLighT-xY91 do you need any help with this? |
4 participants
Description:
This PR moves
examples/account_allowance_approve_transaction_hbar.pyinto the correct folder:examples/account/account_allowance_approve_transaction_hbar.pyRelated issue(s):
Fixes #1004
Notes for reviewer:
N/A
Checklist