Make format_checks as a first required workflow before triggering others

[marko-bekhta]

[Please describe here what your change is about]

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

[mbellade]

When this task was introduced we avoided making the db test runs depend on it to avoid delaying them, when most often that's the most important feedback you want from your PR.

The checks are pretty fast, but still take 1-2 minutes usually.

[marko-bekhta]

yeah, though I'd say that there is no point in consuming the resources to run the db tests if the formatting will fail the build anyway (since we'd waste the runners on the tests to just re-push and re-execute the full build).

this came up as an idea in this zulip discussion: #hibernate-orm-dev > 7.2 CR4 @ 💬

[mbellade]

Sure, I'm just relaying concerns that the team had at the time, which is why I didn't make the build step required. I don't see this suggested in the linked conversation, but if everyone's fine with it I'm +0

[gavinking]

yeah, though I'd say that there is no point in consuming the resources to run the db tests if the formatting will fail the build anyway

I completely disagree with this.

Most of the time we're pushing to CI to see if the substantive functionality actually runs and works on 10 different dbs, not to see if we can get our code past some stupid bot.

It's an incredible waste of my valuable time to force me to correct stupid shit before I can run my tests.