Skip to content

fix: filter bot accounts from contributors list#3765

Merged
mrlubos merged 3 commits intomainfrom
pullfrog/3764-filter-bot-contributors
Apr 14, 2026
Merged

fix: filter bot accounts from contributors list#3765
mrlubos merged 3 commits intomainfrom
pullfrog/3764-filter-bot-contributors

Conversation

@pullfrog
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot commented Apr 14, 2026

Closes #3764

Changes

scripts/update-contributors.sh

Two-layer bot filtering added to the contributor loop:

  1. [bot] suffix check — skips any login ending with [bot] before the API call, catching all standard GitHub bot accounts (e.g. dependabot[bot], pullfrog[bot], renovate[bot]).
  2. API type check — after fetching the user profile, skips accounts where the GitHub API returns type: "Bot". This catches properly registered GitHub Apps that may not follow the [bot] naming convention.

The USERS+= append was moved to after both checks so the contributor count stays accurate.

docs/.contributorsignore

Added a comment explaining that [bot]-suffixed accounts are now filtered automatically. Existing bot entries are kept as a safeguard.

docs/partials/contributors-list.md

Removed the two duplicate pullfrog[bot] entries (lines 118–119).

Pullfrog  | View workflow run | Triggered by Pullfrog𝕏

Add automatic bot filtering to update-contributors.sh:
- Skip logins ending with [bot] suffix
- Skip accounts with GitHub API type "Bot"

Remove duplicate pullfrog[bot] entries from contributors-list.md.

Closes #3764
@pullfrog pullfrog bot requested a review from mrlubos April 14, 2026 06:55
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hey-api-docs Ready Ready Preview, Comment Apr 14, 2026 7:07am

Request Review

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 14, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 14, 2026

⚠️ No Changeset found

Latest commit: de341a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pullfrog pullfrog bot mentioned this pull request Apr 14, 2026
@dosubot dosubot bot added the internal ⚙️ Internal development work. label Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.09%. Comparing base (1557dba) to head (de341a6).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3765   +/-   ##
=======================================
  Coverage   40.09%   40.09%           
=======================================
  Files         521      521           
  Lines       19264    19264           
  Branches     5715     5715           
=======================================
  Hits         7723     7723           
  Misses       9339     9339           
  Partials     2202     2202           
Flag Coverage Δ
unittests 40.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos
Copy link
Copy Markdown
Member

mrlubos commented Apr 14, 2026

@pullfrog remove the needless comment and all bot accounts from the ignore list

@pullfrog
Copy link
Copy Markdown
Contributor Author

pullfrog bot commented Apr 14, 2026

Removed the comment and all bot account entries from .contributorsignore. The script already filters bots automatically via the [bot] suffix check and the GitHub API type field check, so the ignore list entries were redundant.

Task list (2/2 completed)
  • Remove the comment and bot accounts from .contributorsignore
  • Commit and push changes

Pullfrog  | View workflow run | Triggered by Pullfrog𝕏

@mrlubos
Copy link
Copy Markdown
Member

mrlubos commented Apr 14, 2026

@pullfrog remove the contributors ignore file altogether and remove any mention of it from the script

@pullfrog
Copy link
Copy Markdown
Contributor Author

pullfrog bot commented Apr 14, 2026

Deleted docs/.contributorsignore and removed the EXCLUDED_FILE variable and its grep check from scripts/update-contributors.sh. Bot filtering now relies solely on the [bot] suffix check and the GitHub API type field check that were already in place.

Task list (4/4 completed)
  • Understand current state: read the diff and relevant files
  • Remove the .contributorsignore file
  • Remove references to .contributorsignore from the script
  • Self-review, commit, and push

Pullfrog  | View workflow run | Triggered by Pullfrog𝕏

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 14, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 14, 2026
@mrlubos mrlubos merged commit 148ed86 into main Apr 14, 2026
9 checks passed
@mrlubos mrlubos deleted the pullfrog/3764-filter-bot-contributors branch April 14, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal ⚙️ Internal development work. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up contributors

1 participant