fix(openapi-ts): fix generated infiniteQueryOptions not work with useSuspenseInfiniteQuery#3205
Conversation
|
|
|
|
@manudeli is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
| .pretty() | ||
| .hint('@ts-ignore') | ||
| .prop('initialPageParam', $.object().pretty().as('any')) | ||
| .prop('getNextPageParam', $.func().as('any')) |
There was a problem hiding this comment.
This feels very dirty. Is the issue that the inferred type doesn't contain initialPageParam and getNextPageParam? Why not add a second argument and require them?
There was a problem hiding this comment.
Why not add a second argument and require them?
Could you give me code example please? I need more detail
| tags: [], | ||
| }, | ||
| }), | ||
| getNextPageParam: (lastPage) => lastPage.map(({ name }) => name), |
There was a problem hiding this comment.
What would happen if you omit this line? Would the types not complain? Would the runtime code likely crash?
There was a problem hiding this comment.
like below
In the original implementation, even if we omitted getNextPageParam, TypeScript didn’t complain either
| }, | ||
| }), | ||
| getNextPageParam: (lastPage) => lastPage.map(({ name }) => name), | ||
| initialPageParam: { query: { tags: [] } }, |
There was a problem hiding this comment.
The other reason this smells is if you place this line BEFORE the generated options, it won't get applied. I think we either want to keep options as they were (not setting this property) or require this property if it's needed
Enhance the OpenAPI configuration to include pagination options and update the App component to utilize both infinite and suspense infinite queries for fetching pets by tags. Introduce new utility functions for infinite query handling in the generated client code.
manudeli
force-pushed
the
fix/react-query/infiniteQueryOptions-should-work-with-useSuspenseInfiniteQuery
branch
from
8ba03a1 to
e1e8f8f
Compare
dosubot
bot
added
size:L
2 participants
fix: #2931