Skip to content

Handle nil body from store in queue processing #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericmj merged 2 commits into from
Feb 7, 2026
Merged

Handle nil body from store in queue processing #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
180976c
Handle nil body from store in queue processing
ericmj Feb 7, 2026
6f7600c
Fix test port collision by using OS-assigned ports
ericmj Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/hexdocs/queue.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,16 @@ defmodule Hexdocs.Queue do

body = Hexdocs.Store.get(:repo_bucket, key)

case type do
:upload ->
process_upload(key, repository, package, version, body, start)
if body do
case type do
:upload ->
process_upload(key, repository, package, version, body, start)

:search ->
process_search(key, repository, package, version, body, start)
:search ->
process_search(key, repository, package, version, body, start)
end
else
Logger.error("#{log_prefix} #{key}: package not found in store")
end

:error ->
Expand Down
5 changes: 2 additions & 3 deletions test/hexdocs/http_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ defmodule Hexdocs.HTTPTest do
end

setup do
port = Enum.random(50_000..60_000)
start_supervised!({Plug.Cowboy, plug: StreamingPlug, scheme: :http, port: port})
{:ok, port: port}
start_supervised!({Plug.Cowboy, plug: StreamingPlug, scheme: :http, port: 0})
{:ok, port: :ranch.get_port(StreamingPlug.HTTP)}
end

describe "get_stream/2" do
Expand Down
4 changes: 2 additions & 2 deletions test/hexdocs/plug_gs_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ defmodule Hexdocs.PlugGSTest do
:ets.delete_all_objects(:mock_gcs_files)

# Start mock GCS server
port = Enum.random(50_000..60_000)
start_supervised!({Plug.Cowboy, plug: MockGCSPlug, scheme: :http, port: port})
start_supervised!({Plug.Cowboy, plug: MockGCSPlug, scheme: :http, port: 0})
port = :ranch.get_port(MockGCSPlug.HTTP)

# Configure to use GS store with mock server
original_store_impl = Application.get_env(:hexdocs, :store_impl)
Expand Down