docs: fix server metrics example#547
Merged
jooola merged 1 commit intohetznercloud:mainfrom Aug 26, 2025
Merged
Conversation
Member
|
Hey, thanks for the contribution :) |
The existing version has 2 problems: - the iso-formatted dates need a timezone in order to work with the API - Object of type Metrics is not JSON serializable anymore.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 64 64
Lines 2945 2945
=======================================
Hits 2844 2844
Misses 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing examples/get_server_metrics.py version has 2 problems:
So i added an explicit UTC timezone for the datetime objects, and got rid of the json.dumps() at the end of the script.