Use Boost::json in olp-cpp-sdk-dataservice-read#1684
Merged
rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom Mar 17, 2026
Merged
Use Boost::json in olp-cpp-sdk-dataservice-read#1684rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom
rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom
Conversation
Migrating from RapidJSON Relates-To: OCMAM-444 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
force-pushed
the
rga/ocmam-444-boost-to-read-copy-includes
branch
from
57cd050 to
5615b9a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature_boost_json #1684 +/- ##
=====================================================
Coverage ? 80.51%
=====================================================
Files ? 355
Lines ? 14071
Branches ? 1527
=====================================================
Hits ? 11329
Misses ? 2128
Partials ? 614 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This allows to keep other libs untouched until fully migrated to the boost::json and remove read lib dependency from public json wrappers. Alternative solutions tried are: - add boost json wrappers to the same files in the core but to additional namespace - changes in core, json still exposed - move boost json wrappers from core to internal for the repository include location and add it to all DataSDK projects - huge change Relates-To: OCMAM-444 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
force-pushed
the
rga/ocmam-444-boost-to-read-copy-includes
branch
from
5615b9a to
25c3cd7
Compare
rustam-gamidov-here
requested review from
andrey-kashcheev,
asopov-here,
khomenkd and
mykolamalik
andrey-kashcheev
approved these changes
Mar 16, 2026
mykolamalik
approved these changes
Mar 17, 2026
rustam-gamidov-here
deleted the
rga/ocmam-444-boost-to-read-copy-includes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Boost::json in olp-cpp-sdk-dataservice-read
Migrating from RapidJSON
Copy json implementation wrappers to read lib
This allows to keep other libs untouched until fully migrated to the
boost::json and remove read lib dependency from public json wrappers.
Alternative solutions tried are:
additional namespace - changes in core, json still exposed
include location and add it to all DataSDK projects - huge change
Relates-To: OCMAM-444