fix: honor --release-name instead of generating a random release name#841
Open
somaz94 wants to merge 1 commit into
Open
fix: honor --release-name instead of generating a random release name#841somaz94 wants to merge 1 commit into
somaz94 wants to merge 1 commit into
Conversation
Signed-off-by: somaz <genius5711@gmail.com>
Author
|
Gentle ping 🙏 — green and ready for review. This makes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ct install --release-name <name>was ignored.Chart.CreateInstallParamsonly honored the release name when the chart path resolved to.or/, and unconditionally appended a random suffix — so--release-name go-backendstill producedhelm install go-backend-<random>(see the reproduction in the issue). This uses the provided--release-nameverbatim as the release name (Helm validates the syntax). The namespace derivation is unchanged.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #198Special notes for your reviewer:
TestChart_CreateInstallParamsinpkg/chart/chart_test.go(fails before the fix: the release came out assimple-deployment-<random>instead ofmy-release).go test ./...,go vet ./pkg/chart/,gofmt -l, andgolangci-lint run ./pkg/chart/...are all clean locally.--namespace go-backend --release-name go-backendthe caller now yieldshelm install go-backend --namespace go-backend.