Skip to content

Working on fixing the links#1258

Merged
VisLab merged 3 commits intohed-standard:mainfrom
VisLab:fix_extras
Mar 6, 2026
Merged

Working on fixing the links#1258
VisLab merged 3 commits intohed-standard:mainfrom
VisLab:fix_extras

Conversation

@VisLab
Copy link
Member

@VisLab VisLab commented Mar 6, 2026

No description provided.

uv pip install -e ".[dev,test,docs,examples]"
git submodule update --init --recursive # fetch test data
pytest tests/ --cov
unittest tests/ --cov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important: unittest tests/ --cov is not valid syntax. unittest is not a standalone CLI command, and it does not accept --cov. This was previously pytest tests/ --cov (the correct command) and was regressed in this PR.

Suggested change
unittest tests/ --cov
pytest tests/ --cov

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

PR Review summary for this PR (inline comment also posted on CLAUDE.md line 16): The only important issue found is a regression in CLAUDE.md where pytest tests/ --cov was changed to unittest tests/ --cov. This is invalid: unittest is not a standalone CLI tool and does not accept --cov. The original pytest tests/ --cov should be restored. All other changes look correct: the html_meta front matter in user_guide.md is the proper MyST replacement for the old meta directive, removing -e from the links workflow install is fine since only doc-building is needed, adding .ruff_cache/ to .gitignore is correct, and the submodule bumps are routine.

@VisLab VisLab merged commit 96c6681 into hed-standard:main Mar 6, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant