Skip to content

Renamed check_warnings to check_for_warnings for consistency#1253

Merged
VisLab merged 3 commits intohed-standard:mainfrom
VisLab:fix_extras
Mar 4, 2026
Merged

Renamed check_warnings to check_for_warnings for consistency#1253
VisLab merged 3 commits intohed-standard:mainfrom
VisLab:fix_extras

Conversation

@VisLab
Copy link
Member

@VisLab VisLab commented Mar 4, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

PR Review: Rename check_warningscheck_for_warnings

Verdict: LGTM

This is a clean, minimal rename for consistency with the rest of the codebase (e.g., ErrorHandler, check_compliance, BIDS tools, CLI all use check_for_warnings).

Checked:

  • No remaining uses of the old check_warnings keyword argument anywhere in the repo.
  • validate_schema and validate_schema_object are internal script utilities, not exported from hed/__init__.py, so there is no public API breakage.
  • The only external callers (validate_schemas.py, hed_convert_schema.py) call validate_all_schemas, which in turn calls validate_schema with no keyword argument, so the rename has no impact there.
  • All test methods and docstrings updated consistently.
  • The added inline comment (# Ensure errors are listed before warnings) correctly explains the issues = errors + warnings reassignment.

No issues found.

@VisLab VisLab merged commit da162a4 into hed-standard:main Mar 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant