Skip to content

v2.6.14: 更新禁漫发布页地址和测试case#514

Merged
hect0x7 merged 2 commits intomasterfrom
dev
Feb 20, 2026
Merged

v2.6.14: 更新禁漫发布页地址和测试case#514
hect0x7 merged 2 commits intomasterfrom
dev

Conversation

@hect0x7
Copy link
Owner

@hect0x7 hect0x7 commented Feb 20, 2026

Summary by CodeRabbit

  • Chores

    • Bumped package version to 2.6.14.
    • Updated application version constant to 2.0.18.
  • Updates

    • Updated public module URL to https://jmcomicgo.org for domain access.

@coderabbitai
Copy link

coderabbitai bot commented Feb 20, 2026

📝 Walkthrough

Walkthrough

This release updates package and application versions, changes the public module URL from https://jmcomic-fb.vip to https://jmcomicgo.org, modifies test I/O handling to preserve pytest's capture mechanism, and adjusts a test search parameter.

Changes

Cohort / File(s) Summary
Version & Configuration Updates
src/jmcomic/__init__.py, src/jmcomic/jm_config.py
Bumped package __version__ to 2.6.14, updated APP_VERSION to 2.0.18, and changed JM_PUB_URL to https://jmcomicgo.org.
Test Infrastructure & Parameters
tests/test_jmcomic/__init__.py, tests/test_jmcomic/test_jm_client.py
Modified stdout/stderr initialization to use reconfigure(encoding='utf-8') instead of object replacement to preserve pytest I/O capture; changed test_search_params case 152637 order_by parameter from ORDER_BY_LIKE to ORDER_BY_VIEW.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 Versions hop and URLs bound,
Two-point-eighteen's brand new ground!
Pytest's streams now flow just right,
Config changes—hopping bright!
thump thump 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: version bump to 2.6.14 and updates to the publication URL and test cases, which are the primary modifications across the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hect0x7 hect0x7 merged commit 9ef2185 into master Feb 20, 2026
7 of 9 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/test_jmcomic/__init__.py (1)

8-13: Add an explicit import sys for robustness.

sys is used at lines 10–13 but not explicitly imported — it's only available transitively via from jmcomic import *. This is fragile: if the star-import chain ever changes, these lines will raise a NameError. Ruff also flags this (F405). The reconfigure() approach itself is correct and the right fix for preserving pytest's capture.

♻️ Proposed fix
 import platform
 import unittest
+import sys

 # noinspection PyUnresolvedReferences
 import jmcomic
 from jmcomic import *
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@tests/test_jmcomic/__init__.py` around lines 8 - 13, The module uses sys
(sys.stdout.reconfigure and sys.stderr.reconfigure) without importing it, which
can cause NameError and ruff F405; add an explicit import sys at the top of the
module (before any use of sys) so the references to sys, sys.stdout.reconfigure,
and sys.stderr.reconfigure are resolved reliably and the linter error is fixed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@tests/test_jmcomic/__init__.py`:
- Around line 8-13: The module uses sys (sys.stdout.reconfigure and
sys.stderr.reconfigure) without importing it, which can cause NameError and ruff
F405; add an explicit import sys at the top of the module (before any use of
sys) so the references to sys, sys.stdout.reconfigure, and
sys.stderr.reconfigure are resolved reliably and the linter error is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant