Fix OutOfMemoryError in reference component

[reggie7]

Fix for #163, but I had to use #184 fix for #164. The core fix is this commit.

[flx-sta]

This seems to fix the backend-part of the issue 🚀 .
@reggie7 please have a look at my question.

Im not sure though why the frontend even allows to reference a page to itself.
Is there an issue to fix this? that it shouldn't be allowed in the first place

[reggie7]

Im not sure though why the frontend even allows to reference a page to itself.
Is there an issue to fix this? that it shouldn't be allowed in the first place

@Felix-Puetz hmm, we can discuss that. What do you think @reusr1?
It's not that easy, though, as just an assumption that same page can't be referenced only. There's more to it. We can't allow any loop of references actually. This requires a call to the server so that it can check it properly.

[reusr1]

@Felix-Puetz I think a ref to the page itself is ok
@reggie7 looking at this PR I am a bit worried about the performance implication of this code, have to think about this a bit more

[reusr1]

currently a no, need to figure out if this change has a performance implication/if there is no cleaner way to handle this

[reusr1]

@reggie7 can we not solve this much more performant with the introduction of a threadlocal variable at

themeclean-flex/core/src/main/java/com/themecleanflex/models/ReferenceModel.java

Line 576 in 08ce5cc

ResourceResolver resourceResolver = getResource().getResourceResolver();

that makes sure we dont output the same resource multiple times?

[reggie7]

@Felix-Puetz I think a ref to the page itself is ok
@reggie7 looking at this PR I am a bit worried about the performance implication of this code, have to think about this a bit more

Sure, take your time, it is indeed doing a recursive search to avoid recursive includes.

[reusr1]

@Felix-Puetz I think a ref to the page itself is ok
@reggie7 looking at this PR I am a bit worried about the performance implication of this code, have to think about this a bit more

Sure, take your time, it is indeed doing a recursive search to avoid recursive includes.

@reggie7 I think you missed my last comment - I am suggesting to use a threadlocal variable to handle this instead