Closed
Conversation
… objects on the window
…ect cant be found
reusr1
requested changes
Aug 20, 2020
Contributor
reusr1
left a comment
reusr1
left a comment
There was a problem hiding this comment.
- we are missing a way to tell the author that the form schema is invalid while working on the schema
- we need better samples
- general code cleanup as mentioned in the review
…o console.log, removed id from failure message div
reusr1
reviewed
Aug 20, 2020
…ng from error paragraphs
Collaborator
|
Added styles to this component. And removed depublicate submit button in all-inputs schema.
|
Collaborator
|
Component now allows button to be aligned left/center/right, and ability to change size
|
Open
Collaborator
Author
|
I am closing this in favor of directly pulling in the issues/156 branch in the pull request 162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Will solve #136 by updating the form component to be more useable.