Skip to content

Feat/modify fitness score#38

Merged
Jiahe114514 merged 2 commits intomainfrom
feat/ModifyFitnessScore
Feb 28, 2026
Merged

Feat/modify fitness score#38
Jiahe114514 merged 2 commits intomainfrom
feat/ModifyFitnessScore

Conversation

@Jiahe114514
Copy link
Contributor

@Jiahe114514 Jiahe114514 commented Feb 28, 2026

Summary by CodeRabbit

新增功能和改进

  • 新功能

    • 添加了修改体测成绩的功能,支持更新已保存的体测数据(包括身高、体重、50米跑等多项指标)。
  • 改进

    • 优化了删除体测成绩的接口,使职员ID、学年和学期参数变为可选项,提高使用灵活性。

@Jiahe114514 Jiahe114514 merged commit ef01eb4 into main Feb 28, 2026
1 check passed
@coderabbitai
Copy link

coderabbitai bot commented Feb 28, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7a767e and aea330c.

⛔ Files ignored due to path filters (3)
  • campusapis/staff/v1/campus.pb.go is excluded by !**/*.pb.go
  • campusapis/staff/v1/campus.pb.gw.go is excluded by !**/*.pb.gw.go
  • campusapis/staff/v1/campus_grpc.pb.go is excluded by !**/*.pb.go
📒 Files selected for processing (2)
  • campusapis/staff/v1/campus.proto
  • docs/swagger/campusapis/staff/v1/campus.swagger.json

工作流概述

向 CampusService 添加了新的 RPC 方法 ModifyFitnessScore,用于修改体测成绩,同时引入了相应的请求消息类型。删除了 DeleteFitnessScoreRequest 的 OpenAPI 架构注解,并相应更新了 Swagger 文档中的 API 定义和参数配置。

变更内容

组织 / 文件 摘要
Proto 定义更新
campusapis/staff/v1/campus.proto
添加新的 ModifyFitnessScore RPC 方法及对应的 ModifyFitnessScoreRequest 消息类型,包含 staffId、schoolYear、semester 和多个体测指标字段。删除了 DeleteFitnessScoreRequest 的 OpenAPI 架构注解。
Swagger 文档同步
docs/swagger/campusapis/staff/v1/campus.swagger.json
添加两个 PUT 操作端点 CampusService_ModifyFitnessScoreCampusService_ModifyFitnessScore2,引入 v1ModifyFitnessScoreRequest 数据模型,并将 DeleteFitnessScore 操作的 staffId、schoolYear、semester 参数从必需改为可选。

预期代码审查工作量

🎯 3 (中等) | ⏱️ ~20 分钟

可能相关的 PR

  • chore: fitness data storage #32: 两个 PR 都修改了 campus.proto 中的体测成绩 RPC 接口——该 PR 添加了 ModifyFitnessScore/ModifyFitnessScoreRequest 并移除了 DeleteFitnessScoreRequest 的 OpenAPI 架构,而该相关 PR 则添加了 Store/Update/Delete 操作和体测数据的请求/响应类型。

诗歌

🐰 体测数据修改来,
新的端点已铺开,
Proto 与 Swagger 齐更新,
参数灵活可有可无,
校园 API 再添彩!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/ModifyFitnessScore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant