Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #790 +/- ##
=======================================
Coverage 94.43% 94.44%
=======================================
Files 398 399 +1
Lines 25932 25997 +65
=======================================
+ Hits 24489 24552 +63
- Misses 1443 1445 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuce
changed the title
# Conflicts: # hazelcast/internal/asyncio_client.py
| self._invocation_service.invoke(invocation) | ||
| return invocation.future | ||
|
|
||
| async def _ainvoke_on_target( |
There was a problem hiding this comment.
method only called from one place, Executor._execute_on_member. why do you introduce yet another utility method like this instead of awaiting at the called method?
| except SchemaNotReplicatedError as e: | ||
| return await self._send_schema_and_retry(e, self.execute_on_members, members, task) | ||
|
|
||
| uuid = uuid4() |
There was a problem hiding this comment.
The uuid is unique for each call to each member at Java client(see https://github.com/hazelcast/hazelcast-mono/blob/d2d3c923d45982e80047954849a560dc85762821/hazelcast/hazelcast/src/main/java/com/hazelcast/client/impl/proxy/ClientExecutorServiceProxy.java#L511). Can you test and fix this same as Java?
3 participants
Straightforward port of Executor proxy, and its tests to asyncio