Skip to content

dontfrag for WINE#605

Open
kazu-yamamoto wants to merge 2 commits into
haskell:masterfrom
kazu-yamamoto:dontfrag-wine
Open

dontfrag for WINE#605
kazu-yamamoto wants to merge 2 commits into
haskell:masterfrom
kazu-yamamoto:dontfrag-wine

Conversation

@kazu-yamamoto
Copy link
Copy Markdown
Collaborator

This should fix #604.

Cc: @hamishmack

@hamishmack
Copy link
Copy Markdown

I've added a flake.nix file in #606 that can be used to run the tests using cross compilation and wine on a x86_64-linux machine with nix installed. Just run nix flake check. I also included a .github/workflow/haskell-nix.yml file to run it (untested).

This PR does seem to fix the failures it has with socket, but there are some others as well.

Failures:

  .\System\IO\Temp.hs:114:3:
  1) Network.Socket.bind successfully binds to a unix socket
       uncaught exception: IOException of type OtherError
       Network.Socket.socket: failed (Address family not supported by protocol family (WSAEAFNOSUPPORT))

  To rerun use: --match "/Network.Socket/bind/successfully binds to a unix socket/" --seed 243449885

  tests\Network\SocketSpec.hs:135:15:
  2) Network.Socket, ifNameToIndex and ifIndexToName, convert a name to an index and back
       not expected: Nothing

  To rerun use: --match "/Network.Socket/ifNameToIndex and ifIndexToName/convert a name to an index and back/" --seed 243449885

  tests\Network\Socket\ByteStringSpec.hs:218:41:
  3) Network.Socket.ByteString.recvMsg receives truncated flag
       expected: MsgFlag {
                   fromMsgFlag = 256
                 }
        but got: MsgFlag {
                   fromMsgFlag = 0
                 }

  To rerun use: --match "/Network.Socket.ByteString/recvMsg/receives truncated flag/" --seed 243449885

@harendra-kumar
Copy link
Copy Markdown

This is a problem only on old Windows systems. I enabled network 3.2.8 in streamly and noticed that windows build on github with Windows (MINGW64_NT-10.0-26100) succeeds but on appveryor with (MSYS_NT-6.3-9600) it fails.

This PR should fix it, but I am wondering if we should make it conditional for older Windows system, though I am not sure in which Windows version it starts succeeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WINE Network.Socket.setSockOpt:failed(Badprotocoloption(WSAENOPROTOOPT))

3 participants