Skip to content

Fix and find typos in hs sources#11501

Merged
mergify[bot] merged 1 commit intohaskell:masterfrom
cabalism:typo/hs-sources
Mar 6, 2026
Merged

Fix and find typos in hs sources#11501
mergify[bot] merged 1 commit intohaskell:masterfrom
cabalism:typo/hs-sources

Conversation

@philderbeast
Copy link
Collaborator

@philderbeast philderbeast commented Feb 21, 2026

A follow on from #10603, check for typos in *.hs and other source files. I didn't change the existing configuration we use for spell checking the docs or the method of supplying *.rst and *.md files but I did change their Makefile recipes to take an explicit --config option, renaming their config file to .typos-docs.yml:

- .typos.yml
+ .typos-docs.yml
+ .typos-srcs.yml

Adds two Makefile .PHONY targets for finding and fixing typos and a GitHub action for finding these typos. Updated .typos-srcs.yml to accept abbreviations we use and some misspellings.

$ make help
...
hs-fix-typos                   Fix typos in Haskell source files; .hs, .cabal, etc.
hs-typos                       Find typos in Haskell source files; .hs, .cabal, etc.
markdown-fix-typos             Fix typos in markdown files
markdown-typos                 Find typos in markdown files
typos-install                  Install typos-cli for typos target using cargo
users-guide-fix-typos          Fix typos in users guide
users-guide-typos              Find typos in users guide

I'll squash commits before applying the merge label if this pull request is approved.


@philderbeast philderbeast marked this pull request as draft February 21, 2026 12:21
@philderbeast philderbeast marked this pull request as ready for review February 21, 2026 17:04
@philderbeast philderbeast force-pushed the typo/hs-sources branch 3 times, most recently from 80c1c51 to 3cb752f Compare February 25, 2026 18:16
@philderbeast philderbeast force-pushed the typo/hs-sources branch 4 times, most recently from 4c1ceab to 9cc81a9 Compare March 1, 2026 18:56
@philderbeast philderbeast force-pushed the typo/hs-sources branch 2 times, most recently from 13cbfe0 to cdeacc3 Compare March 2, 2026 12:37
@philderbeast philderbeast requested review from Bodigrim and ffaf1 March 2, 2026 14:34
@philderbeast philderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Mar 2, 2026
- Configure typos for hs abbreviations and allowed misspellings
- Fix typo inherithed
- Fix typo succesfully
- Fix typo environmnet
- Fix typo ther
- Add more abbreviations and misspellings
- Fix typo uncessary
- Fix typo becuase
- Fix typo Uknown
- Remove false hits from dist-newstyle
- Add an hs-fix-typos .PHONY target
- Exclude non-existent files
- Exclude path dist-newstyle
- Do path exclusions one per line
- Add make hs-typos to typos workflow
- Fix typo ReportUserTargerNonexistantFile
- Rename files to all-test-suite.*
- Bump typo to v1.43.5
- Use separate config for typos for docs & srcs
- Add .typos-hs.toml
- Use explicit --config with typos
- Fix typo --formar in changelog for haskell#1903
- Rename to .typos-srcs.toml
- Trigger ci run on push
- Fix typo comparision
- Fix typo limt
- Fix typo appropiate
- Fix typo preprocesser
- Fix typo verstion
- Fix typo cylical
- Fix typo synopsys
- Add a changelog entry
- Exclude the changelog entry with a typo
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Mar 3, 2026
mergify bot added a commit that referenced this pull request Mar 5, 2026
@mergify mergify bot added dequeued and removed queued labels Mar 5, 2026
@philderbeast
Copy link
Collaborator Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Mar 5, 2026

Merge Queue Status

Rule: default


This pull request spent 2 hours 4 minutes 50 seconds in the queue, including 1 hour 54 minutes 41 seconds running CI.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@mergify mergify bot added queued and removed dequeued labels Mar 5, 2026
mergify bot added a commit that referenced this pull request Mar 5, 2026
@mergify mergify bot added dequeued and removed queued labels Mar 5, 2026
@geekosaur
Copy link
Collaborator

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 5, 2026

Merge Queue Status

Rule: default


This pull request spent 1 hour 56 minutes 58 seconds in the queue, including 1 hour 46 minutes 3 seconds running CI.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@mergify mergify bot added queued and removed dequeued labels Mar 5, 2026
mergify bot added a commit that referenced this pull request Mar 5, 2026
@mergify mergify bot added dequeued and removed queued labels Mar 5, 2026
@geekosaur
Copy link
Collaborator

windows-latest 9.2.8 again. try it later.

@geekosaur
Copy link
Collaborator

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2026

Merge Queue Status

Rule: default


This pull request spent 1 hour 55 minutes 32 seconds in the queue, including 1 hour 45 minutes 8 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify mergify bot added queued and removed dequeued labels Mar 6, 2026
@geekosaur
Copy link
Collaborator

Should be rebased on top of master by Mergify, which is now skipping windows-9.2.8 until we sort out wtf's going on.

mergify bot added a commit that referenced this pull request Mar 6, 2026
@mergify mergify bot merged commit 863616d into haskell:master Mar 6, 2026
403 checks passed
@mergify mergify bot removed the queued label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants