Skip to content

Conversation

@geekosaur
Copy link
Collaborator

I swear I tested the previous fix before pushing…

cabal-install version 3.17.0.0(commit 37e110e on HEAD, Fri Dec 26 02:50:57 2025 +0000)
compiled using version 3.17.0.0 of the Cabal library 

Space re-added. (Still need to figure out why the Cabal git information is missing.)


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur force-pushed the version-spacing-again branch from f887be4 to c9532b0 Compare December 26, 2025 14:22
@geekosaur geekosaur marked this pull request as draft December 26, 2025 14:29
@geekosaur geekosaur force-pushed the version-spacing-again branch from 07e0383 to ad01460 Compare December 26, 2025 16:18
@geekosaur
Copy link
Collaborator Author

Next push I'll remove the debugging stuff and put it back in the debugging PR, since I've proved I didn't make things (half-)work with all the hackery in the debug PR's validate.yml.

@geekosaur geekosaur force-pushed the version-spacing-again branch from ad01460 to c9532b0 Compare December 26, 2025 17:38
@geekosaur geekosaur marked this pull request as ready for review December 26, 2025 17:39
@geekosaur geekosaur added the merge me Tell Mergify Bot to merge label Dec 26, 2025
@geekosaur
Copy link
Collaborator Author

I'll finish debugging on the debug PR. I do note that the last build seems to have suggested that somehow Cabal is being built without -DGIT_REV even though my local builds get it, which may mean I missed something in either Cabal.cabal or cabal.validate.project.

@geekosaur
Copy link
Collaborator Author

Also, that's two network-related failures so far on the latest build. GitHub's evidently having a good day….

@geekosaur geekosaur removed the merge me Tell Mergify Bot to merge label Dec 26, 2025
@geekosaur
Copy link
Collaborator Author

Got it, testing on test PR, will add that change here and re-label afterward.

That still leaves #11340: if our CI actually is including it, what if anything is being done differently there? /cc: @AndreasPK

@geekosaur geekosaur added the squash+merge me Tell Mergify Bot to squash-merge label Dec 27, 2025
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Dec 27, 2025
@geekosaur
Copy link
Collaborator Author

Someone might want to re-review given the flags fix.

@mergify mergify bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Dec 29, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2025

Merge Queue Status

✅ The pull request has been merged at ddf7a65

This pull request spent 10 minutes 48 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify mergify bot merged commit 6b8ed5f into haskell:master Dec 29, 2025
207 checks passed
@mergify mergify bot removed the queued label Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period squash+merge me Tell Mergify Bot to squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants