Addition of paletteSize, while removing private field of Palette'#184
Open
lehins wants to merge 1 commit intohaskell-github-trust:masterfrom
Open
Addition of paletteSize, while removing private field of Palette'#184lehins wants to merge 1 commit intohaskell-github-trust:masterfrom
paletteSize, while removing private field of Palette'#184lehins wants to merge 1 commit intohaskell-github-trust:masterfrom
Conversation
Collaborator
|
At this point, while this is a worthwhile enhancement, I wouldn't break compatibility for such "low" issue, has to keep it in mind in case of bigger breaking change |
Contributor
Author
|
@Twinside I agree, that bundling this together with a bigger breaking change is a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I gather
_paletteSizeis an unnecessary field inPalette', since it can be deduced from the size of_paletteDataand the type of pixel, which is exactly the way that the newly addedpaletteSizeis implemented. Couple benefits that come from this change:Palette'is now anewtypearoundVector, hence slight reduction to memory usage and overall improvement to performance_paletteSizethat is coupled to the actual data allows construction of incorrectPalette', which opens a possibility of a segfault when using images converted from such palettes bypalettedAsImage