Make it compile with MicroHs#77
Make it compile with MicroHs#77RyanGlScott merged 2 commits intohaskell-compat:masterfrom konsumlamm:master
Conversation
|
I fixed the bitrotten CI in 3d13612. Can you rebase your changes on top of that commit? |
|
If I understand correctly, the approach here is to simply not define any instances at all when using non-GHC compilers. Is that correct? What should be the story for supporting MicroHs versions of |
Yes.
MicroHs will match future changes of GHC's |
|
I want MicroHs to match |
|
And it's pointless to support older MicroHs version. There are not enough users. |
RyanGlScott
left a comment
There was a problem hiding this comment.
Thanks! In that case, I'll go ahead and merge this as-is.
Only depend on
ghc-primfor GHC 9.0 (since it's only needed for importingSoloonbase-4.15, which was shipped with GHC 9.0). MicroHs doesn't support olderbaseversions and the code contains a lot of GHC-specific stuff, so guard it with__GLASGOW_HASKELL__.I can add a MicroHs CI if you want, but I will also add
base-orphansto MicroHs' CI, so that the latest (Stackage) release ofbase-orphansis always tested against the latest MicroHs build.