ci(contracts): add deployment testing workflow and harden CI pipeline#837
Merged
MiguelLZPF merged 1 commit intodevelopmentfrom Feb 17, 2026
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
5323af6 to
585ef97
Compare
709e07a to
6bf0a1e
Compare
Add automated CI deployment testing and apply security/reliability improvements across all GitHub Actions workflows. Deployment Testing: - New 100-flow-ats-deployment-test.yaml with Hardhat + Hiero Solo jobs - Shared build job with dependency and artifact caching - Hiero Solo integration via hiero-solo-action v0.16.0 - Docker availability check for graceful Solo job skipping Workflow Hardening: - Upgrade actions/checkout v4.2.2 → v5.0.0 across all workflows - Pin actions/cache to v4.2.3 with commit SHA - Add timeout-minutes to all jobs (5/15/45 min by type) - Add defaults.run.shell: bash and concurrency controls - Add codecov action version annotation - Update npm to 11.7.0 in mass-payout publish Script Improvements: - Replace 195 parallel RPC calls with synchronous registry lookups - Wrap signer with NonceManager for nonce caching prevention - Add timing output to registry generation task - Fix ethers v6 API in diamondCutManager test - Add selector conflict validation test Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
6bf0a1e to
04e7366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add automated CI deployment testing and apply security/reliability improvements across all GitHub Actions workflows.
Deployment Testing
100-flow-ats-deployment-test.yamlworkflow with Hardhat and Hiero Solo jobshiero-solo-actionv0.16.0Workflow Hardening
actions/checkoutv4.2.2 → v5.0.0 across all workflowsactions/cacheto v4.2.3 with commit SHAtimeout-minutesto all jobs (5/15/45 min by type)defaults.run.shell: bashand concurrency controlsScript Improvements
NonceManagerto prevent nonce caching issues during deploymentTest Improvements
diamondCutManagertest (keccak256, contract address accessor)SelectorAlreadyRegisterederror)Type of change
Testing
diamondCutManagerNode version:
Checklist