Skip to content

ci(contracts): add deployment testing workflow and harden CI pipeline#837

Merged
MiguelLZPF merged 1 commit intodevelopmentfrom
feat/BBND-1373-ci-deployment-workflow
Feb 17, 2026
Merged

ci(contracts): add deployment testing workflow and harden CI pipeline#837
MiguelLZPF merged 1 commit intodevelopmentfrom
feat/BBND-1373-ci-deployment-workflow

Conversation

@MiguelLZPF
Copy link
Copy Markdown
Contributor

@MiguelLZPF MiguelLZPF commented Feb 10, 2026

Description

Add automated CI deployment testing and apply security/reliability improvements across all GitHub Actions workflows.

Deployment Testing

  • New 100-flow-ats-deployment-test.yaml workflow with Hardhat and Hiero Solo jobs
  • Shared build job with dependency and artifact caching to eliminate duplication
  • Hiero Solo integration via hiero-solo-action v0.16.0
  • Docker availability check for graceful Solo job skipping

Workflow Hardening

  • Upgrade actions/checkout v4.2.2 → v5.0.0 across all workflows
  • Pin actions/cache to v4.2.3 with commit SHA
  • Add timeout-minutes to all jobs (5/15/45 min by type)
  • Add defaults.run.shell: bash and concurrency controls
  • Add codecov action version annotation
  • Update npm to 11.7.0 in mass-payout publish

Script Improvements

  • Replace 195 parallel RPC calls with synchronous registry lookups in facet registration
  • Wrap signer with NonceManager to prevent nonce caching issues during deployment
  • Add timing output and type-safe error handling to registry generation task

Test Improvements

  • Fix ethers v6 API in diamondCutManager test (keccak256, contract address accessor)
  • Add selector conflict validation test (SelectorAlreadyRegistered error)

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

  • Deployment test workflow validates contracts compile and deploy on Hardhat local network
  • Hiero Solo job tests deployment against a real Hedera-compatible node (requires Docker)
  • Existing unit and integration tests pass with script improvements
  • Selector conflict validation test added for diamondCutManager

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

@hedera-eng-infrastructure
Copy link
Copy Markdown

hedera-eng-infrastructure commented Feb 10, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@MiguelLZPF MiguelLZPF self-assigned this Feb 10, 2026
@MiguelLZPF MiguelLZPF force-pushed the feat/BBND-1373-ci-deployment-workflow branch 11 times, most recently from 5323af6 to 585ef97 Compare February 13, 2026 11:53
@MiguelLZPF MiguelLZPF marked this pull request as ready for review February 13, 2026 12:30
@MiguelLZPF MiguelLZPF requested review from a team as code owners February 13, 2026 12:30
@MiguelLZPF MiguelLZPF added New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. CI | CD Changes related to CI CD, GitHub Actions, pipeline Contracts Changes related to the “contracts” module labels Feb 13, 2026
Copy link
Copy Markdown
Contributor

@luigi-io luigi-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@MiguelLZPF MiguelLZPF force-pushed the feat/BBND-1373-ci-deployment-workflow branch from 709e07a to 6bf0a1e Compare February 16, 2026 11:23
@MiguelLZPF MiguelLZPF changed the title ci(contracts): add deployment testing workflow for ATS contracts ci(contracts): add deployment testing workflow and harden CI pipeline Feb 16, 2026
Add automated CI deployment testing and apply security/reliability
improvements across all GitHub Actions workflows.

Deployment Testing:
- New 100-flow-ats-deployment-test.yaml with Hardhat + Hiero Solo jobs
- Shared build job with dependency and artifact caching
- Hiero Solo integration via hiero-solo-action v0.16.0
- Docker availability check for graceful Solo job skipping

Workflow Hardening:
- Upgrade actions/checkout v4.2.2 → v5.0.0 across all workflows
- Pin actions/cache to v4.2.3 with commit SHA
- Add timeout-minutes to all jobs (5/15/45 min by type)
- Add defaults.run.shell: bash and concurrency controls
- Add codecov action version annotation
- Update npm to 11.7.0 in mass-payout publish

Script Improvements:
- Replace 195 parallel RPC calls with synchronous registry lookups
- Wrap signer with NonceManager for nonce caching prevention
- Add timing output to registry generation task
- Fix ethers v6 API in diamondCutManager test
- Add selector conflict validation test

Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
@MiguelLZPF MiguelLZPF force-pushed the feat/BBND-1373-ci-deployment-workflow branch from 6bf0a1e to 04e7366 Compare February 17, 2026 07:54
@MiguelLZPF MiguelLZPF merged commit 04e7366 into development Feb 17, 2026
17 checks passed
@MiguelLZPF MiguelLZPF deleted the feat/BBND-1373-ci-deployment-workflow branch February 17, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI | CD Changes related to CI CD, GitHub Actions, pipeline Contracts Changes related to the “contracts” module New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants