refactor: Move IMediator interface to abstractions package#45
Open
SpireX64 wants to merge 1 commit intohasanxdev:mainfrom
Open
refactor: Move IMediator interface to abstractions package#45SpireX64 wants to merge 1 commit intohasanxdev:mainfrom
SpireX64 wants to merge 1 commit intohasanxdev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved
IMediatorinto the abstractions package :)The idea is pretty simple:
IMediatoris an abstract interface, and in many places I don’t actually need the whole DispatchR package with its implementation.For example:
IMediatorinterface.IMediatorfor side effects.In these cases pulling the full DispatchR package feels like overkill — having just the abstractions is enough and keeps dependencies cleaner.
Overall this isn’t a super important change, but it should be a bit more convenient for the cases above 😄