Fix elementhandle-misc.spec.ts headful test failures#162
Closed
Conversation
The ShouldUncheckTheBox test was missing the `checked` attribute on the input element, diverging from upstream. Without it, Playwright's uncheck is a no-op on an already-unchecked checkbox, but in headful mode the click-based uncheck path could hang waiting for state change. Update the test HTML to match upstream (`<input ... checked>`) and remove the overly-broad headful expected-failure entry. Closes #113 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShouldUncheckTheBoxtest to match upstream: add missingcheckedattribute to the checkbox input element so uncheck actually transitions state instead of being a no-op[elementhandle-misc.spec.ts] *headful expected-failure entry fromTestExpectations.local.jsonCloses #113
Test plan
dotnet build ./src/PlaywrightSharp.slnpasses with zero errorsElementHandleMiscTestspass in headless mode:dotnet test --filter "ClassName=PlaywrightSharp.Tests.ElementHandleMiscTests" -f netcoreapp3.1ElementHandleMiscTestspass in headful mode:HEADLESS=false dotnet test --filter "ClassName=PlaywrightSharp.Tests.ElementHandleMiscTests" -f netcoreapp3.1elementhandle-misc.spec.tsentry is no longer inTestExpectations.local.json🤖 Generated with Claude Code