Fix page-accessibility tests: broken Equals and outdated expectations#161
Closed
Fix page-accessibility tests: broken Equals and outdated expectations#161
Conversation
…ectations The root cause was AccessibilitySnapshotResult.Equals(object) calling base.Equals(obj) (reference equality) instead of the typed Equals method, causing all NUnit Is.EqualTo() assertions to fail. Also updates test expectations to match upstream: autofocus wait, Chromium role changes (img->image, vertical orientation on menu), Multiline on contenteditable textbox, and adds missing tests (title, aria-invalid). Removes incorrect browser skip annotations on tests that upstream runs on all browsers. Closes #89 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccessibilitySnapshotResult.Equals(object)calledbase.Equals(obj)(reference equality fromObject) instead of the typedEquals(AccessibilitySnapshotResult)method. Every NUnitIs.EqualTo()comparison on these objects silently failed.WaitForFunctionAsyncfor autofocus race condition, updated Chromium roles (img->image), addedMultiline = truefor contenteditable textbox, fixedorientation: verticalfor Chromium menus, platform-conditional WebKit expectations.NonEditableTextbox...,CheckboxWith..., andCheckboxWithout...tests were restricted to Chromium-only but upstream runs them on all browsers.ShouldWorkWhenThereIsATitleandShouldWorkWithAriaInvalidAccessibilityTreefrom upstream.Closes #89
Test plan
PRODUCT=CHROMIUM dotnet test ... --filter "ClassName~PageAccessibility"PRODUCT=FIREFOX dotnet test ... --filter "ClassName~PageAccessibility"PRODUCT=WEBKIT dotnet test ... --filter "ClassName~PageAccessibility"Equals(object)fix🤖 Generated with Claude Code