Fix elementhandle-owner-frame headful test failures#160
Closed
Conversation
The elementhandle-owner-frame tests were incorrectly marked as expected failures in headful mode. These tests perform basic DOM operations (navigate, attach frames, evaluate handles, check owner frames) that have no headful-specific behavior differences. The test code matches upstream Playwright exactly. The expectation entry was bulk-added due to CI infrastructure issues, not actual code bugs. Remove the wildcard expected-failure entry for headful mode. Closes #114 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[elementhandle-owner-frame.spec.ts] *wildcard expected-failure entry for headful mode fromTestExpectations.local.jsonTest plan
ElementHandleOwnerFrameTestspass in headless mode (default CI)ElementHandleOwnerFrameTestsare no longer skipped in headful mode (HEADLESS=false)Closes #114
🤖 Generated with Claude Code