Skip to content

Fix emulation-focus headful test failures #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kblok wants to merge 1 commit into from
Closed

Fix emulation-focus headful test failures #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/PlaywrightSharp.Nunit/TestExpectations/TestExpectations.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,6 @@
"parameters": ["headful"],
"expectations": ["FAIL"]
},
{
"testIdPattern": "[emulation-focus.spec.ts] *",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["headful"],
"expectations": ["FAIL"]
},
{
"testIdPattern": "[eval-on-selector-all.spec.ts] *",
"platforms": ["darwin", "linux", "win32"],
Expand Down
7 changes: 6 additions & 1 deletion src/PlaywrightSharp.Tests/EmulationFocusTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ await TaskUtils.WhenAll(

var popup = popupTask.Result;

Assert.That(await Page.EvaluateAsync<bool>("document.hasFocus()"), Is.True);
Assert.That(await popup.EvaluateAsync<bool>("document.hasFocus()"), Is.True);
Assert.That(await Page.EvaluateAsync<bool>("document.hasFocus()"), Is.True);
}

[PlaywrightTest("emulation-focus.spec.ts", "should provide target for keyboard events")]
Expand Down Expand Up @@ -128,6 +128,11 @@ public void ShouldNotAffectScreenshots()
[Test, Timeout(TestConstants.DefaultTestTimeout)]
public async Task ShouldChangeFocusedIframe()
{
if (TestConstants.IsFirefox && !TestConstants.IsHeadless)
{
Assert.Ignore("Headed Firefox might lose focus");
}

await Page.GoToAsync(TestConstants.EmptyPage);

var (frame1, frame2) = await TaskUtils.WhenAll(
Expand Down
1 change: 1 addition & 0 deletions src/PlaywrightSharp.Tests/TestConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ internal static Task<IBrowser> LaunchDefaultHeadful(
internal static readonly bool IsChromium = Product.Equals(ChromiumProduct, StringComparison.OrdinalIgnoreCase);
internal static readonly bool IsMacOSX = RuntimeInformation.IsOSPlatform(OSPlatform.OSX);
internal static readonly bool IsWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
internal static readonly bool IsHeadless = Convert.ToBoolean(Environment.GetEnvironmentVariable("HEADLESS") ?? "true");

public static readonly IEnumerable<string> NestedFramesDumpResult = new List<string>()
{
Expand Down
Loading