Fix failing test: page-add-init-script cross-origin navigation (headful)#156
Closed
Fix failing test: page-add-init-script cross-origin navigation (headful)#156
Conversation
…oss-origin test The ShouldWorkAfterACrossOriginNavigation test was incorrectly marked as an expected failure in headful mode. This test performs pure protocol-level operations (navigation, init script registration, script evaluation) with no headful-specific dependencies -- it does not depend on rendering, focus, viewport, or any visual display behavior. The test code matches upstream Playwright exactly, and upstream has no test expectations for this test. Closes #128 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the incorrect headful expected-failure entry for page-add-init-script cross-origin test. The test performs pure protocol-level operations with no headful-specific dependencies and matches upstream exactly. Closes #128