Closed
Conversation
The page-fill tests failed in headful mode because several tests called
Page.ClickAsync() on date/time/datetime-local inputs before filling them.
In headful mode, clicking these inputs opens native date/time picker
dialogs that block the subsequent fill operation, causing timeouts.
Changes to match upstream Playwright tests:
- Remove Page.ClickAsync("input") before fill on time, datetime-local,
incorrect date, incorrect time, and incorrect datetime-local tests
- Remove "range" from unsupported input types (now supported by server)
- Add "invalid-type" to fillable input types list
- Update incorrect date test value from "2020-13-02" to "2020-13-05"
- Rename ShouldFillTimeInputAfterClicking to ShouldFillTimeInput
- Use case-insensitive assertion for error messages
- Remove expected-failure entry from TestExpectations.local.json
Closes #125
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page.ClickAsync("input")calls before fill operations on date/time/datetime-local inputs that caused native picker dialogs to open in headful mode, blocking the fill and causing timeoutsrangefrom unsupported input types list (the Playwright server now supports filling range inputs)invalid-typeto fillable input types, use case-insensitive error message assertion, and update test value to match upstream[page-fill.spec.ts] *headful expected-failure entry fromTestExpectations.local.jsonCloses #125
Test plan
dotnet build ./src/PlaywrightSharp.slnsucceedsdotnet test ./src/PlaywrightSharp.Tests/PlaywrightSharp.Tests.csproj --filter "ClassName=PlaywrightSharp.Tests.PageFillTests" -f netcoreapp3.1HEADLESS=false dotnet test ./src/PlaywrightSharp.Tests/PlaywrightSharp.Tests.csproj --filter "ClassName=PlaywrightSharp.Tests.PageFillTests" -f netcoreapp3.1[page-fill.spec.ts]in headful mode🤖 Generated with Claude Code