Closed
Conversation
Two root causes fixed: 1. ShouldReportDifferentFrameInstanceWhenFrameReAttaches waited for FrameNavigated instead of FrameAttached (matching upstream), causing timeouts in headful mode where event timing differs. 2. DumpFrames did not sort child frames by URL then name, unlike upstream, leading to non-deterministic ordering in ShouldHandleNestedFrames. Added missing PageEvent.FrameAttached to enable WaitForEventAsync usage. Removed the [frame-hierarchy.spec.ts] expected-failure entry. Closes #122 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShouldReportDifferentFrameInstanceWhenFrameReAttachesto wait forFrameAttachedinstead ofFrameNavigated, matching upstream Playwright behavior. The wrong event caused timeouts in headful mode where event timing differs from headless.PageEvent.FrameAttachedto enableWaitForEventAsync(PageEvent.FrameAttached).FrameUtils.DumpFramesto sort child frames by URL then name, matching upstream's deterministic ordering and preventing non-deterministic test failures.[frame-hierarchy.spec.ts] *expected-failure entry fromTestExpectations.local.json.Closes #122
Test plan
dotnet build ./src/PlaywrightSharp.slnpasses with zero errorsHEADLESS=false dotnet test ./src/PlaywrightSharp.Tests/PlaywrightSharp.Tests.csproj --filter "ClassName=PlaywrightSharp.Tests.FrameHierarchyTests" -f net10.0dotnet test ./src/PlaywrightSharp.Tests/PlaywrightSharp.Tests.csproj --filter "ClassName=PlaywrightSharp.Tests.FrameHierarchyTests" -f net10.0🤖 Generated with Claude Code