BUG/MAJOR: service: deep-copy cr-backend spec to fix cross-service server contamination#802
Open
cxfcxf wants to merge 1 commit into
Open
BUG/MAJOR: service: deep-copy cr-backend spec to fix cross-service server contamination#802cxfcxf wants to merge 1 commit into
cxfcxf wants to merge 1 commit into
Conversation
…rver contamination
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Can we expect it to be merged soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#795
we have same bug, this fix the bug
this cause way bigger issue since we run multiple backends with external mode.
the actually backend SRV would duplicate and override each other, its not really a drift but totally broke when pod ip gets changed on a rolling upgrade case
deepcopy would avoid this
the actually block that cause it
https://github.com/haproxytech/kubernetes-ingress/blob/master/pkg/service/service.go#L227-L238