Update typescript, typedoc, vuepress & eslint#1258
Merged
Conversation
Performance comparison of head (1b34854) vs base (104ce4c) |
Contributor
Author
|
It's OK. Neither |
wszymanski
suggested changes
May 18, 2023
Contributor
wszymanski
left a comment
There was a problem hiding this comment.
It works as desired. Just one minor remark.
.config/webpack/languages.js
Outdated
Contributor
There was a problem hiding this comment.
Could you move it above declaring variables?
Contributor
Author
There was a problem hiding this comment.
Turns out this require statement is not needed here. I removed it.
Codecov Report
@@ Coverage Diff @@
## develop #1258 +/- ##
========================================
Coverage 97.19% 97.19%
========================================
Files 166 166
Lines 14238 14238
Branches 2965 2965
========================================
Hits 13838 13838
Misses 400 400
|
wszymanski
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I reduced number of critical vulnerabilities from 7 to 2. To fix the rest we need to update:
Which require a lot of effort. Draft PR: #1262
How did you test your changes?
Types of changes
Related issues:
Fixes #1239
Checklist: