Open
Conversation
mcourteaux
commented
Mar 8, 2026
Comment on lines
+1473
to
+1475
| Profiled<ExtractBlockSize> block_size; | ||
| block_size.profiled_visit(op); | ||
| Stmt loop(op); |
Contributor
Author
There was a problem hiding this comment.
@alexreinking Can you validate this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Proof-of-Concept PR. I tried to be minimally invasive:
Profiled<...>to get the version that profiles the visit functions.ZoneScopedmacro (and a few variants) times a scope, using the function name in which it sits.IRVisitor::profiled_visit(),IRMutator::profiled_mutate(), andIRGraphVisitor::profiled_include(), to be sure you can profile the IRVisitor/Mutator without necessarily profiling the entire IR tree being walked.To use this:
-DWITH_COMPILER_PROFILING. When this is not passed, the code is compiled as before with zero runtime overhead.HL_COMPILER_TRACE_FILE=somefile.trace.jsonas environment variable. If this variable is not set, no profiling events will be collected, nor written.Example trace file: vector_shuffle.trace.json
With sample screenshot:
This work led to #8996