Open
Conversation
stubs never really moved beyond proof-of-concept. E.g. there is no cmake support for them, and the one app that uses them has no build. This PR removes them entirely. Opened for discussion. Co-authored-by: Claude Code <noreply@anthropic.com>
alexreinking
reviewed
Mar 4, 2026
Member
alexreinking
left a comment
alexreinking
left a comment
There was a problem hiding this comment.
In principle, I agree with this change. It removes a source of extreme complexity with no users. Almost 2000 lines removed is a remarkable metric. We should probably send a notice to the mailing list, in case anyone there is reading and cares to weigh in.
alexreinking
added
the
release_notes
Member
|
This PR should also drop the |
# Conflicts: # src/Module.h
Member
|
This PR should probably drop the Python equivalent (Pystubs), too. |
Member
Author
|
@vksnk is this going to break anything inside Google? Not sure if there are internal uses of stubs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stubs never really moved beyond proof-of-concept. E.g. there is no cmake support for them, and the one app that uses them has no build.
This PR removes them entirely. Opened for discussion.
Closes #8735