Vulkan: export allocator for custom contexts#8871
Open
xFile3160 wants to merge 1 commit intohalide:mainfrom
Open
Vulkan: export allocator for custom contexts#8871xFile3160 wants to merge 1 commit intohalide:mainfrom
xFile3160 wants to merge 1 commit intohalide:mainfrom
Conversation
Author
|
Full discussion available here: #8715 (comment) |
Member
|
@derek-gerstmann could you review this PR? Seems you were discussing the related issue. |
Author
|
Any news about this? Should I rebase? |
Add documented hooks that let an override of halide_vulkan_acquire_context return its own VkInstance/device yet still bootstrap Halide's allocator. The weak runtime now exposes halide_vulkan_export_memory_allocator/halide_vulkan_memory_allocator_release plus a vk_release_memory_allocator helper that only tears down Halide-owned caches. VulkanContext will lazily allocate+export Halide's allocator when an override returns nullptr. Example integration and validation lives at 9041848.
Member
|
Hi @xFile3160 -- happy new year! Yes, please rebase (looks like you just did). I'll ping @derek-gerstmann again to look at this since he has in-depth knowledge of the Vulkan backend. |
Contributor
|
Thanks for the reminder! I'll look this over this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documented hooks that let an override of halide_vulkan_acquire_context return its own VkInstance/device yet still bootstrap Halide's allocator. The weak runtime now exposes halide_vulkan_export_memory_allocator/halide_vulkan_memory_allocator_release plus a vk_release_memory_allocator helper that only tears down Halide-owned caches.
VulkanContext will lazily allocate+export Halide's allocator when an override returns nullptr. Example integration and validation lives at xFile3160@9041848.