Fix lowering of pow() in D3D12Compute when the base is provably positive#8813
Merged
mcourteaux merged 3 commits intomainfrom Feb 5, 2026
Merged
Fix lowering of pow() in D3D12Compute when the base is provably positive#8813mcourteaux merged 3 commits intomainfrom
mcourteaux merged 3 commits intomainfrom
Conversation
slomp
approved these changes
Sep 17, 2025
Contributor
slomp
left a comment
There was a problem hiding this comment.
Thanks for spotting the issue and fixing it!
alexreinking
approved these changes
Sep 22, 2025
Contributor
|
Glancing at this PR, I wonder why the original code was bad. Why doesn't |
Member
Apparently it doesn't return an rvalue expression in all cases. It ought to, imo, but that would be out of scope for this PR. |
Member
|
Getting some incorrect values on webgpu -- that must be an llvm_main injection. |
Contributor
|
@alexreinking I think we can land this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an internal report of a codegen error when lowering
pow()in the D3D12Compute backend, producing incorrect HLSL like the following:pow(_183, float _367 = _364 * _364;The root issue was that this lowering path was directly injecting into the string representing the shader, rather than using a lowering path that will handle dealing with the arguments correctly. Also added a test that failed before this change; I can separate it out to its own file if that's better.