fix/handle text_special and text_join rule causing incorrect position and size with escaped links#19
Merged
Yukaii merged 3 commits intohackmdio:masterfrom Aug 28, 2025
Merged
Conversation
Yukaii
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
\go throughrules_core/text_join.mjsand are converted fromtext_specialtotextand merged before other rules run. Causing later rules to lose the correct position info.Fixes
positionandsizewhen merging adjacent text tokens.sizewhen creating atext_specialtoken inrules_inline/escape.mjsto preserve the correct size before stripping the escape token.Others
\nin some cases).GPT-5 saved it 🙏