Add new config option allowVisibleSource

[roman-yatsenko]

Add new config option allowVisibleSource to the project. The default value for this option is true. The false value will block Edit and Both editor modes for users that have no rights to edit a note.

Pull request adds:

• new config option allowVisibleSource with default value true;
• new environment variable CMD_VISIBLE_SOURCE;
• disable Edit and Both modes for users without edit note permission;
• redirect form Edit and Both modes to View mode by direct URL with mode parameter.

[a60814billy]

To prevent broken current behavior, set the default value to false

[roman-yatsenko]

With the default value true user can see note source (edit and both modes are enabled for view to user without edit rights). The true value is an usual CodiMD behavior for now.
P.S. But we've refactored as you wish :-)

[a60814billy]

following coding convention,
change the environment variable name to CMD_ALLOW_VISIBLE_SOURCE

[a60814billy]

Suggested change

	throw new Error('one or more parametr is incorrect')
	throw new Error('one or more parameter is incorrect')

[a60814billy]

Suggested change

	} else return allowVisibleSource(isLogin, permission)
	}
	return allowVisibleSource(isLogin, permission)

[a60814billy]

Using more precise function name here.
Maybe can change disableControlsto disableModeChangeControls and
enableControls to enableModeChangeControls

[a60814billy]

Suggested change

	function checkParametr (isLogin, permission) {
	function checkParameter (isLogin, permission) {

[a60814billy]

replaceUrl -> replaceUrlToViewMode

[a60814billy]

function userIsLogin (userPersonalInfo) {
  return !!userPersonalInfo && !!userPersonalInfo.login
}

[a60814billy]

introduce a function isAllowUserChangeMode

function isAllowUserChangeMode () {
  const isOwner = personalInfo.userid && window.owner && personalInfo.userid === window.owner
  return isOwner || !blockSourceView
}

and mode select logic would be

if (isAllowUserChangeMode()) {
    return toggleMode()
}

[a60814billy]

Hi @roman-yatsenko, thanks for your contribution, It's a good feature.
But we need some refactoring to meet project coding conventions before merge.

[a60814billy]

By the way, please sign DCO

[roman-yatsenko]

By the way, please sign DCO

We have a git problems with DCO commit signs (Can't sign done commits). Can we accept the pull request without DCO? Or we can create a new pull request with one signed commit with all code.
What we need to do?

[a60814billy]

Hi, @roman-yatsenko
Due to AGPL licesne, we can't accept any code without DCO sign. Please open a new pull request to do it!

[roman-yatsenko]

Recreated at #1621