Conversation
d7857f7 to
8bf5304
Compare
There was a problem hiding this comment.
Pull request overview
Updates the bundled TinyUSB stack to align with upstream v3.7.3, adding/refreshing multiple class drivers and modernizing the Adafruit ArduinoCore integration layer.
Changes:
- Syncs in additional/updated TinyUSB class driver headers/sources (CDC host/device, DFU, MSC host, MIDI host/device, HID host, networking, BTH, Audio).
- Refactors Adafruit ArduinoCore abstractions (USBD device/interface/CDC) and adds a dedicated port API + nRF implementation.
- Adjusts CI dependency resolution (PlatformIO platform source) and removes the legacy README.
Reviewed changes
Copilot reviewed 48 out of 259 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/net/ncm.h | Adds NCM definitions/config for networking class support. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/net/ecm_rndis_device.c | Adds ECM/RNDIS device implementation for TinyUSB networking. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/msc/msc_host.h | Adds MSC host public API declarations. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/msc/msc_host.c | Adds MSC host implementation including enumeration logic. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/msc/msc_device.h | Updates MSC device API/callback contracts (async I/O, inquiry v2, etc.). |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/msc/msc.h | Updates MSC/SCSI common definitions and comments. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/midi/midi_host.h | Adds MIDI host API. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/midi/midi_device.h | Updates MIDI device API (stream/packet split + deprecated aliases). |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/midi/midi.h | Updates MIDI constants and descriptor definitions. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/hid/hid_host.h | Adds HID host API definitions. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/dfu/dfu_rt_device.h | Refactors DFU runtime header, centralizing DFU types into dfu.h. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/dfu/dfu_rt_device.c | Refactors DFU runtime control handling and logging. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/dfu/dfu_device.h | Adds DFU mode device public API + callbacks. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/dfu/dfu_device.c | Adds DFU mode device state machine implementation. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/dfu/dfu.h | Adds shared DFU protocol/types header. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/cdc/serial/pl2303.h | Adds PL2303 USB-serial protocol constants/types. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/cdc/serial/ftdi_sio.h | Adds FTDI SIO protocol constants/types. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/cdc/serial/cp210x.h | Adds CP210x protocol constants/types. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/cdc/serial/ch34x.h | Adds CH34x protocol constants/types and defaults. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/cdc/cdc_host.h | Adds CDC host API definitions. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/cdc/cdc_device.h | Updates CDC device API, configuration, callbacks, and notifications. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/cdc/cdc.h | Updates CDC common constants/types (line coding/state, notifications, descriptors). |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/bth/bth_device.h | Updates BTH device API and adds historical compatibility option. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/bth/bth_device.c | Refactors BTH device implementation (buffers, ZLP behavior, control xfer staging). |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/audio/audio_device.h | Adds/updates Audio device API surface and driver hooks. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/README.md | Removes legacy README from the submodule snapshot. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/Adafruit_USBD_Interface.h | Refactors USBD interface abstraction into a standalone header. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/Adafruit_USBD_Interface.cpp | Implements updated interface helper(s) (string descriptor). |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/Adafruit_USBD_Device.h | Refactors device abstraction (descriptor mgmt, endpoints, strings, lifecycle). |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/Adafruit_USBD_CDC.h | Refactors CDC Arduino wrapper to use new interface/device model. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/Adafruit_USBD_CDC.cpp | Implements revamped CDC wrapper w/ multi-instance and touch1200 integration. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/Adafruit_TinyUSB_nrf.cpp | Adds nRF TinyUSB port implementation and RTOS task wiring. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/Adafruit_TinyUSB_API.h | Adds shared TinyUSB core+port API contract. |
| cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/Adafruit_TinyUSB_API.cpp | Implements Arduino-facing TinyUSB glue (millis timebase, flush, debug printf). |
| cores/nRF5/Arduino.h | Switches TinyUSB include to the new CDC header for USE_TINYUSB. |
| .github/workflows/build.yml | Updates PlatformIO platform reference used in CI builds. |
Comments suppressed due to low confidence (1)
cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/README.md:1
- This file is removed entirely in the update. If this documentation is still needed for consumers of this bundled core, consider keeping a slim README (or moving it elsewhere in-repo) so users can discover porting guidance and integration entry points.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/midi/midi.h
Show resolved
Hide resolved
cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/bth/bth_device.c
Show resolved
Hide resolved
cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/net/ecm_rndis_device.c
Show resolved
Hide resolved
cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/msc/msc_host.c
Show resolved
Hide resolved
cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/msc/msc_device.h
Show resolved
Hide resolved
cores/nRF5/TinyUSB/Adafruit_TinyUSB_ArduinoCore/tinyusb/src/class/bth/bth_device.h
Show resolved
Hide resolved
8bf5304 to
a2bcdf8
Compare
a2bcdf8 to
1cc2299
Compare
1cc2299 to
9e47ef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.