feat!: set golang mvs true as default#188
Merged
ruromero merged 2 commits intoguacsec:mainfrom Oct 31, 2025
Merged
Conversation
ruromero
force-pushed
the
feat/mvs
branch
8 times, most recently
from
fbdcfa7 to
f1df165
Compare
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
This was referenced Nov 29, 2025
soul2zimate
added a commit
that referenced
this pull request
Nov 29, 2025
…VersionsForModule (#225) ## Description fix: correct go path for commands executed in method getFinalPackagesVersionsForModule This happens because [`getFinalPackagesVersionsForModule`](https://github.com/guacsec/trustify-da-java-client/blob/v0.0.10/src/main/java/io/github/guacsec/trustifyda/providers/GoModulesProvider.java#L319-L323) doesn't use the resolved go executable path. This is uncovered by #188 which set the use of the MVS algorithm default to true and trigger the `getFinalPackagesVersionsForModule` method by default. **Related issue (if any):** fixes #224 ## Checklist - [x] I have followed this repository's contributing guidelines. - [x] I will adhere to the project's code of conduct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set the use of the MVS algorithm default to
trueas it is the default behaviour in GoRelated issue (if any):
fixes #174
fixes #192
Checklist