core,xds: Fix backend_service plumbing for subchannel metrics#12735
Open
becomeStar wants to merge 1 commit intogrpc:masterfrom
Open
core,xds: Fix backend_service plumbing for subchannel metrics#12735becomeStar wants to merge 1 commit intogrpc:masterfrom
becomeStar wants to merge 1 commit intogrpc:masterfrom
Conversation
Subchannel metrics read backend_service from EAG attributes, but xDS only populated the resolution result attribute. As a result, grpc.lb.backend_service was unset for subchannel metrics in the cds path. Add an internal EAG-level backend_service attribute in cds and have InternalSubchannel read it for subchannel metrics, while keeping a fallback to the existing resolution result attribute. This change is scoped to grpc#12432 and does not attempt the broader grpc#12431 plumbing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #12432.
Subchannel metrics read backend_service from EAG attributes, but xDS currently only populates the resolution result attribute. As a result, grpc.lb.backend_service is left unset for subchannel metrics in the cds path.
This change adds an internal EAG-level backend_service attribute in cds and has InternalSubchannel read that attribute for subchannel metrics, while keeping a fallback to the existing resolution result attribute.
This PR is intentionally scoped to subchannel metrics only and does not attempt the broader #12431 plumbing changes.