Fix edge response deserialization for non-binary result types#410
Open
timmarkhuff wants to merge 1 commit intomainfrom
Open
Fix edge response deserialization for non-binary result types#410timmarkhuff wants to merge 1 commit intomainfrom
timmarkhuff wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When submitting an image query to a multi-class (or other non-binary) detector via the edge endpoint, the SDK deserializes the result as
BinaryClassificationResultinstead ofMultiClassificationResult. This happens because:result_typeat theImageQuerylevel but omit it from the nestedresultdict.UniononImageQuery.resultby trying each type in order. Sinceresult_typeisOptionalin all result models,BinaryClassificationResultmatches first due to having the same shape asMultiClassificationResult.This causes
result_type=Noneon the result object, spurious "Unrecognized internal label" warnings, andAttributeErrorwhen accessing fields specific to the correct result type.Fix
Added
_propagate_result_typewhich copies theImageQuery-levelresult_typeinto theresultdict before Pydantic parsing, so theUnionresolves to the correct type. Applied at all three image query deserialization sites:get_image_query,list_image_queries, andsubmit_image_query.